[device/celestica]: Add thermalctld support on DX010 platform APIs #6089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging 751491b into 443f81f - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging ca3aca8 into 0a36de3 - view on LGTM.com new alerts:
|
|
Retest vsimage please |
jleveque
suggested changes
Jan 14, 2021
device/celestica/x86_64-cel_seastone-r0/sonic_platform/thermal_actions.py
Outdated
Show resolved
Hide resolved
|
This pull request introduces 3 alerts when merging 63ddb29 into 58a13b4 - view on LGTM.com new alerts:
|
jleveque
approved these changes
Jan 15, 2021
lguohan
pushed a commit
that referenced
this pull request
Jan 21, 2021
…6089) **- Why I did it** - The thermalctld daemon on the Pmon docker requires support from the thermal manager API. **- How I did it** - Removed the old function for detecting a faulty fan. - Removed the old function for detecting excess temperature. - Implement thermal_manager APIs based on ThermalManagerBase - Implement thermal_conditions APIs based on ThermalPolicyConditionBase - Implement thermal_actions APIs based on ThermalPolicyActionBase - Implement thermal_info APIs based on ThermalPolicyInfoBase - Add thermal_policy.json
abdosi
pushed a commit
that referenced
this pull request
Feb 19, 2021
…6089) **- Why I did it** - The thermalctld daemon on the Pmon docker requires support from the thermal manager API. **- How I did it** - Removed the old function for detecting a faulty fan. - Removed the old function for detecting excess temperature. - Implement thermal_manager APIs based on ThermalManagerBase - Implement thermal_conditions APIs based on ThermalPolicyConditionBase - Implement thermal_actions APIs based on ThermalPolicyActionBase - Implement thermal_info APIs based on ThermalPolicyInfoBase - Add thermal_policy.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)