lldp defect miscellaneous fixes as patches #6118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudhanshukumar22
force-pushed
the
lldp_patch_branch
branch
from
57e7c46
to
c627217
Compare
|
i can see patch 420 is closed and 422 is used. have you adapt this pr to the upstream patch? what i like to see is that you adapt this pr to original commit 422 and update the pr description to reflect that. also please generate your patch properly using git format-patch commit from upstream repo. the patch is not formatted properly. |
sudhanshukumar22
force-pushed
the
lldp_patch_branch
branch
2 times, most recently
from
8290247
to
7315bbd
Compare
@lguohan : Please review the changes. I have updated as per your review comments. |
sudhanshukumar22
force-pushed
the
lldp_patch_branch
branch
from
7315bbd
to
8dde3f0
Compare
|
can you check the build failure? |
sudhanshukumar22
force-pushed
the
lldp_patch_branch
branch
2 times, most recently
from
02be88d
to
6bddc66
Compare
lguohan
reviewed
Dec 24, 2020
src/lldpd/patch/0010-Ported-fix-for-length-exceeded-from-lldp-community.patch
Show resolved
Hide resolved
The details are as follows:
1. 0010-Ported-fix-for-length-exceeded-from-lldp-community.patch
Ported fix lldpd/lldpd#408 from LLDP community.
lib: remove limit on system description length
The limit was introduced in 9c49ced while fixing a memory leak.
The state data is used to ensure we don't interleave operations. We
need to handle the case where the value is truncated because it is
larger than the allocated size.
Fix sonic-net#408.
2. 0011-fix-med-location-len.patch
Ported fix lldpd/lldpd#422 from community.
lib: fix LLDP-MED location parsing in liblldpctl
Some bounds were not checked correctly when parsing LLDP-MED civic
location fields. This triggers out-of-bound reads (no write) in
lldpcli, ultimately leading to a crash.
Fix sonic-net#420
Signed-off-by: sudhanshukumar22 <sudhanshu.kumar@broadcom.com>
sudhanshukumar22
force-pushed
the
lldp_patch_branch
branch
from
6bddc66
to
3e8030f
Compare
lguohan
approved these changes
Jan 5, 2021
lguohan
pushed a commit
that referenced
this pull request
Jan 5, 2021
The details are as follows:
1. 0010-Ported-fix-for-length-exceeded-from-lldp-community.patch
Patch taken from lldpd/lldpd@7824347
lib: remove limit on system description length
The limit was introduced in 9c49ced while fixing a memory leak.
The state data is used to ensure we don't interleave operations. We
need to handle the case where the value is truncated because it is
larger than the allocated size.
Fix issue lldpd/lldpd#408
2. 0011-fix-med-location-len.patch
Patch taken from lldpd/lldpd@5c34794
lib: fix LLDP-MED location parsing in liblldpctl
Some bounds were not checked correctly when parsing LLDP-MED civic
location fields. This triggers out-of-bound reads (no write) in
lldpcli, ultimately leading to a crash.
Fix lldpd/lldpd#420
Signed-off-by: sudhanshukumar22 <sudhanshu.kumar@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details are as follows:
Signed-off-by: sudhanshukumar22 sudhanshu.kumar@broadcom.com
- Why I did it
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)