-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[snmpagent] update submodule #6169
Conversation
e54036c (HEAD, origin/master, origin/HEAD, master) [rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (sonic-net#169) fd1eae7 Set swsscommon logging level (sonic-net#178) 706d504 Improve MockRedis _encode(): so it will work on all types of value (sonic-net#179) 64c93a1 [RFC4292][Namespace]: Fix implementation of RouteUpdater for multi-asic platform (sonic-net#176) b8f19ee [sonic-snmpagent] SONiC physical entity mib extension (sonic-net#168) 6b94ec3 Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code (sonic-net#162) Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Looking at the VS test failure |
@qiluo-msft Looks like swsscommon SonicV2Connector is missing pubsub interface:
Could you please help to resolve this issue? Also, could you please look at small fixup of sonic-net/sonic-snmpagent#181? |
Ack |
It should be fixed in #6197 |
Retest this please |
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
retest this please |
1 similar comment
retest this please |
retest vsimage please |
retest vsimage please |
@qiluo-msft, loosk like is failing, is there a regression in this submodule update? snmp.test_snmp_pfc_counters.test_snmp_pfc_counters |
We are working on it, there is at least one known issue. |
Retest mellanox please |
retest vsimage please |
the test is still failing? can you folks check? |
@stepanblyschak , @qiluo-msft , where are we on this pr? |
retest vsimage please |
@qiluo-msft The test fails because the test gets the interfaces from rfc1213 MIB and description from rfc2863 MIB. Since Vlan has been added to rfc1213 only it fails to get "description". I'm modifying test to work without required 'description'. |
@qiluo-msft Could you please check sonic-net/sonic-mgmt#2782? |
@stepanblyschak, this is not a test issue, but a code issue inside snmpagent. The interfaces in rfc1213 MIB and rfc2863 MIB should be consistent. For this case, you need to add the 'Description' (and also other fields?) to rfc2863, even an empty string is better than nothing. |
Includes below sonic-snmpagent commits ``` dfde06e 2021-01-13 | Revert "[rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (#169)" (#191) [Stepan Blyshchak] 45edd7e 2021-01-04 | [snmpagent] Fix hardcoded qsfp lane count by reading sensor status from DB (#184) [Junchao-Mellanox] 3b72a6f 2021-01-02 | Fix: handle empty LOC_CHASSIS_TABLE (#190) [Qi Luo] 4aad821 2020-12-29 | [sysName]: Implement sysName OID (#185) [SuvarnaMeenakshi] 8efb4bb 2020-12-29 | [rfc1213] fix counter value type (#189) [Stepan Blyshchak] 025483a 2020-12-23 | [RouteUpdater]: Fix multi_asic mock function implementation and multi_asic variable name (#186) [SuvarnaMeenakshi] 381ae47 2020-12-10 | [mibs] b'VLAN_TABLE:' -> 'VLAN_TABLE' (#181) [Stepan Blyshchak] e54036c 2020-12-09 | [rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (#169) [Stepan Blyshchak] fd1eae7 2020-11-24 | Set swsscommon logging level (#178) [Qi Luo] 706d504 2020-11-23 | Improve MockRedis _encode(): so it will work on all types of value (#179) [Qi Luo] 64c93a1 2020-11-16 | [RFC4292][Namespace]: Fix implementation of RouteUpdater for multi-asic platform (#176) [SuvarnaMeenakshi] b8f19ee 2020-11-12 | [sonic-snmpagent] SONiC physical entity mib extension (#168) [Junchao-Mellanox] 6b94ec3 2020-11-05 | Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code (#162) [Qi Luo] ``` Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com> Co-authored-by: Qi Luo <qiluo-msft@users.noreply.github.com>
Includes below sonic-snmpagent commits
- Why I did it
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)