[ipinip.json.j2] align mellanox configuration dst_ip with other platf… #6304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orms Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
prsunny
approved these changes
Dec 28, 2020
|
retest vsimage please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…orms
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
- Why I did it
Mellanox already supports multiple destination IPs in IPinIP tunnel configuration, thus removing mellanox exception for IPinIP configuration.
- How I did it
Removed "dst_ip" field generation in mellanox platform condition.
Sorted the "dst_ip" list, so that it is easier to test against sample configuration in unit tests.
Aligned unit test sample.
- How to verify it
Run sonic-cfggen UT.
Upload image on the switch and run it.
Run decap tests from sonic-mgmt.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
[ipinip.json.j2] align mellanox configuration dst_ip with other platforms
- A picture of a cute animal (not mandatory but encouraged)