Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build]: setup -t option in docker run correctly #6320

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Dec 29, 2020

use bash -t test flag to check if input device is tty or not

Signed-off-by: Guohan Lu lguohan@gmail.com

- Why I did it
TERM variable is not reliable way to detect input device is tty or not.

use bash -t test flag to check if input device is tty or not

- How I did it
use bash -t test flag to check if input device is tty or not

- How to verify it
test under both tty and non-tty env

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

use bash -t test flag to check if input device is tty or not

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan merged commit 727a451 into sonic-net:master Dec 30, 2020
@lguohan lguohan deleted the term branch December 30, 2020 12:57
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Jan 20, 2021
use bash -t test flag to check if input device is tty or not

Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Jan 20, 2021
use bash -t test flag to check if input device is tty or not

Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan added a commit that referenced this pull request Jan 21, 2021
use bash -t test flag to check if input device is tty or not

Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan added a commit that referenced this pull request Jan 25, 2021
use bash -t test flag to check if input device is tty or not

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants