Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-sonic-vs]: reduce the build steps for docker-sonic-vs #6350

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Jan 4, 2021

Signed-off-by: Guohan Lu lguohan@gmail.com

- Why I did it
combine multiple same operation into one operation to reduce
the build steps. this is to avoid max depth exceeded issue
in the build.

- How I did it
combine copy, apt_dpkg operations into one step.

- How to verify it
build docker-sonic-vs.

steps reduce from 131 to 75.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

combine multiple same operation into one operation to reduce
the build steps. this is to avoid max depth exceeded issue
in the build.

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan
Copy link
Collaborator Author

lguohan commented Jan 4, 2021

issue seeing here.

https://sonic-jenkins.westus2.cloudapp.azure.com/job/common/job/sonic-utilities-build-pr/3611/console

23:37:06  Step 126/131 : RUN rm /etc/frr/frr.conf
23:37:06   ---> Running in 7a0d31990a96
23:37:06  Removing intermediate container 7a0d31990a96
23:37:06   ---> fe5f280fbda2
23:37:06  Step 127/131 : RUN mkdir -p /var/warmboot/teamd
23:37:06   ---> Running in 1c536aee5dcc
23:37:06  max depth exceeded

@lguohan
Copy link
Collaborator Author

lguohan commented Jan 4, 2021

the test failure is not related to the change, the change only on docker-sonic-vs

@lguohan lguohan merged commit 6fbd52b into sonic-net:master Jan 5, 2021
@lguohan lguohan deleted the vs branch January 5, 2021 05:58
lguohan added a commit that referenced this pull request Jan 5, 2021
combine multiple same operation into one operation to reduce
the build steps. this is to avoid max depth exceeded issue
in the build.

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants