Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nokia]: Enable Telemetry for armhf and provide required qos files #6364

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

carl-nokia
Copy link
Contributor

@carl-nokia carl-nokia commented Jan 5, 2021

- Why I did it
To enable Telemetry on armhf architecture and provide required qos/buffers files that
config qos reload --no-dynamic-buffer now requires for the Nokia ixs7215

- How I did it
Removed the hardcoded disable of Telemetry in slave.mk for armhf architecture and provided
required qos/buffers files for the config qos reload code to succeed as stubs since they do not
generate buffer settings to Marvell SAI for this MO based role

- How to verify it
config load_minigraph -y succeeds for OC testing

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@qiluo-msft
Copy link
Collaborator

The PR title is not descriptive.

@carl-nokia carl-nokia changed the title Qosbuffers [Nokia]: Enable Telemetry for armhf and provide required qos files Jan 6, 2021
@carl-nokia
Copy link
Contributor Author

Fixed the title - was an oversight. Thanks

slave.mk Outdated Show resolved Hide resolved
Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you revert the change?

@carl-nokia
Copy link
Contributor Author

Reverted the commit with mistake and pushed the one line change to slave.mk
Please take a look - Thank You

@carl-nokia
Copy link
Contributor Author

Retest mellanox please

@lguohan
Copy link
Collaborator

lguohan commented Jan 6, 2021

build test failure irrelavant

@lguohan lguohan merged commit f99dbff into sonic-net:master Jan 6, 2021
lguohan pushed a commit that referenced this pull request Jan 9, 2021
…6364)

* [platform][Nokia]: Add buffers and qos files for config qos reload

   - providing required files

* [platform][armhf]: remove hardcoded disable for Telemetry on armhf

Co-authored-by: Carl Keene <keene@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants