[Platform][nokia]: python3-smbus package add with python3 and jinja fixes #6416
Conversation
device/nokia/armhf-nokia_ixs7215_52x-r0/Nokia-7215/buffers.json.j2
Outdated
Show resolved
Hide resolved
|
No problem - I see what you are saying - I changed the order |
| @@ -21,6 +21,7 @@ RUN apt-get update && \ | |||
| librrd-dev \ | |||
| rrdtool \ | |||
| python-smbus \ | |||
| python3-smbus \ | |||
There was a problem hiding this comment.
Is this needed by the Nokia sonic-platform package? If so , I would prefer that you add it in the install_requires list of your setup.py file. This way it will get installed along with your package, and will not be installed if not needed.
There was a problem hiding this comment.
Yes, it is needed by the Nokia sonic-platform package and we see Arista using it also btw. I attempted adding to install_requires list of setup.py file as you suggested, but it appears that mechanism is at runtime install time and did not work. See error below:
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0xb5731730>: Failed to establish a new connection: [Errno -3] Temporary failure in name resolution')': /simple/python3-smbus/
Build time install solution is preferred I think - putting the package in our debian another way - still working on alternatives other than the current Arista method multiple debians
There was a problem hiding this comment.
@carl-nokia: Ah yes. The vendor's sonic-platform package gets installed in the PMon container at runtime, thus you are correct, my suggestion will not work. I am OK with this solution for now. Sorry to trouble you.
…ixes (#6416) fix platform driver breakage due to python3 upgrade and fix load minigraph errors with config load_minigraph -y **- How I did it** added python3-smbus to the pmon docker template since the previous was python2 specific fixed additional "ord" python2 specific code fixed the jinja templates used by qos reload - the template logic required data to be parsed **- How to verify it** run "show platform XXX" commands and verify output run "sudo config load_minigraph -y" and verify configuration run "show interfaces XXX" and verify output Co-authored-by: Carl Keene <keene@nokia.com>
- Why I did it
fix platform driver breakage due to python3 upgrade and fix load minigraph errors with config load_minigraph -y
- How I did it
added python3-smbus to the pmon docker template since the previous was python2 specific
fixed additional "ord" python2 specific code
fixed the jinja templates used by qos reload - the template logic required data to be parsed
- How to verify it
run "show platform XXX" commands and verify output
run "sudo config load_minigraph -y" and verify configuration
run "show interfaces XXX" and verify output
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)