Enable PG drop counters by default #6444

ayurkiv-nvda · 2021-01-14T00:08:09Z

Signed-off-by: Andriy Yurkiv ayurkiv@nvidia.com

depends on :
sonic-net/sonic-swss#1600 ,
sonic-net/sonic-utilities#1355

merge priority:
sonic-net/sonic-swss#1600
sonic-net/sonic-utilities#1355
#6444

- Why I did it
PG drop counters should be enabled by default

- How I did it
Add PG drop counter enable option to dockers/docker-orchagent/enable_counters.py

- How to verify it
run counterpoll show CLI command and then you will see PG_STAT_DROP enabled there

- Which release branch to backport (provide reason below if selected)

201811
201911
202006
202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

…ault Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

ayurkiv-nvda · 2021-01-14T21:38:40Z

retest this please

ayurkiv-nvda · 2021-01-15T08:45:44Z

retest baseimage please

volodymyrsamotiy · 2021-01-15T10:16:03Z

@neethajohn, could you you please review?

ayurkiv-nvda · 2021-01-16T17:32:45Z

retest vsimage please

liat-grozovik · 2021-01-19T15:08:02Z

@neethajohn if this is needed for 201911 please add the proper label

liat-grozovik · 2021-01-27T21:01:03Z

/AzurePipelines run

azure-pipelines · 2021-01-27T21:01:13Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-01-28T11:04:38Z

/AzurePipelines run

azure-pipelines · 2021-01-28T11:04:48Z

Azure Pipelines successfully started running 1 pipeline(s).

neethajohn · 2021-02-16T21:54:56Z

/AzurePipelines run

azure-pipelines · 2021-02-16T21:55:09Z

Azure Pipelines successfully started running 1 pipeline(s).

…ew FlexCounter group (#1600) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on : sonic-net/sonic-utilities#1355 sonic-net/sonic-buildimage#6444 What I did Added new option for "counterpoll" util Why I did it Add appropriate code to counterpoll/main.py How I verified it admin@arc-switch1041:~$ counterpoll pg-drop enable --> enable new counter admin@arc-switch1041:~$ counterpoll show --> check new PG_DROP_STAT counter status check counters admin@arc-switch1041:~$ redis-cli -n 2 127.0.0.1:6379[2]> HGETALL COUNTERS:oid:0x1a000000000062 1) "SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES" 2) "0" 3) "SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES" 4) "0" 5) "SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS" 6) "0"

…er in counterpoll utility (#1355) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on: sonic-net/sonic-buildimage#6444 sonic-net/sonic-swss#1600 - What I did Added new option for "counterpoll" utility - How I did it Enhance counterpoll utility for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS Add new CLI command and extend the show command. - How to verify it To test it use QoS test. run the pfcxontest and Pfcxofftest, drop can be triggered in either of the test. It runs in ptf32 topo and requires RPC image. admin@arc-switch1041:~$ counterpoll pg-drop enable --> to enable the new counter admin@arc-switch1041:~$ counterpoll show --> check new INGRESS_PG_STAT_DROP counter status

liat-grozovik · 2021-02-17T17:25:33Z

/AzurePipelines run

azure-pipelines · 2021-02-17T17:25:45Z

Azure Pipelines successfully started running 1 pipeline(s).

abdosi · 2021-02-19T02:12:36Z

@neethajohn do we need this for 201911. Looks to be enhancement

@rlhui

liat-grozovik · 2021-02-19T06:23:24Z

This was an ask for be able to read of drop counters in production environment Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: abdosi <notifications@github.com> Sent: Friday, February 19, 2021 4:12:53 AM To: Azure/sonic-buildimage <sonic-buildimage@noreply.github.com> Cc: Liat Grozovik <liatg@nvidia.com>; Comment <comment@noreply.github.com> Subject: Re: [Azure/sonic-buildimage] Enable PG drop counters by default (#6444) @neethajohn<https://github.com/neethajohn> do we need this for 201911. Looks to be enhancement @rlhui<https://github.com/rlhui> — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#6444 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABAY3CSENZ2PLIX7E7KTS7XCKLANCNFSM4WBTT4CA>.

…ew FlexCounter group (#1600) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on : sonic-net/sonic-utilities#1355 sonic-net/sonic-buildimage#6444 What I did Added new option for "counterpoll" util Why I did it Add appropriate code to counterpoll/main.py How I verified it admin@arc-switch1041:~$ counterpoll pg-drop enable --> enable new counter admin@arc-switch1041:~$ counterpoll show --> check new PG_DROP_STAT counter status check counters admin@arc-switch1041:~$ redis-cli -n 2 127.0.0.1:6379[2]> HGETALL COUNTERS:oid:0x1a000000000062 1) "SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES" 2) "0" 3) "SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES" 4) "0" 5) "SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS" 6) "0"

…er in counterpoll utility (#1355) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on: sonic-net/sonic-buildimage#6444 sonic-net/sonic-swss#1600 - What I did Added new option for "counterpoll" utility - How I did it Enhance counterpoll utility for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS Add new CLI command and extend the show command. - How to verify it To test it use QoS test. run the pfcxontest and Pfcxofftest, drop can be triggered in either of the test. It runs in ptf32 topo and requires RPC image. admin@arc-switch1041:~$ counterpoll pg-drop enable --> to enable the new counter admin@arc-switch1041:~$ counterpoll show --> check new INGRESS_PG_STAT_DROP counter status

…ault (#6444) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

…er in counterpoll utility (sonic-net#1355) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on: sonic-net/sonic-buildimage#6444 sonic-net/sonic-swss#1600 - What I did Added new option for "counterpoll" utility - How I did it Enhance counterpoll utility for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS Add new CLI command and extend the show command. - How to verify it To test it use QoS test. run the pfcxontest and Pfcxofftest, drop can be triggered in either of the test. It runs in ptf32 topo and requires RPC image. admin@arc-switch1041:~$ counterpoll pg-drop enable --> to enable the new counter admin@arc-switch1041:~$ counterpoll show --> check new INGRESS_PG_STAT_DROP counter status

…ew FlexCounter group (sonic-net#1600) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on : sonic-net/sonic-utilities#1355 sonic-net/sonic-buildimage#6444 What I did Added new option for "counterpoll" util Why I did it Add appropriate code to counterpoll/main.py How I verified it admin@arc-switch1041:~$ counterpoll pg-drop enable --> enable new counter admin@arc-switch1041:~$ counterpoll show --> check new PG_DROP_STAT counter status check counters admin@arc-switch1041:~$ redis-cli -n 2 127.0.0.1:6379[2]> HGETALL COUNTERS:oid:0x1a000000000062 1) "SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES" 2) "0" 3) "SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES" 4) "0" 5) "SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS" 6) "0"

bluecmd · 2021-04-13T19:37:17Z

Does this need an associated change to the YANG models?
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-flex_counter.yang#L51

I am getting an error seemingly related to this change on the latest master when setting breakout mode:

sonic_yang(3):All Keys are not parsed in FLEX_COUNTER_TABLE
dict_keys(['PG_DROP'])
sonic_yang(3):exceptionList:[]
sonic_yang(3):Data Loading Failed:All Keys are not parsed in FLEX_COUNTER_TABLE
dict_keys(['PG_DROP'])
Data Loading Failed
All Keys are not parsed in FLEX_COUNTER_TABLE
dict_keys(['PG_DROP'])
ConfigMgmt Class creation failed

neethajohn · 2021-04-13T21:08:48Z

Does this need an associated change to the YANG models?
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-flex_counter.yang#L51

I am getting an error seemingly related to this change on the latest master when setting breakout mode:
sonic_yang(3):All Keys are not parsed in FLEX_COUNTER_TABLE
dict_keys(['PG_DROP'])
sonic_yang(3):exceptionList:[]
sonic_yang(3):Data Loading Failed:All Keys are not parsed in FLEX_COUNTER_TABLE
dict_keys(['PG_DROP'])
Data Loading Failed
All Keys are not parsed in FLEX_COUNTER_TABLE
dict_keys(['PG_DROP'])
ConfigMgmt Class creation failed

Yes. this is a new flex counter table

…ault (sonic-net#6444) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

…ew FlexCounter group (sonic-net#1600) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on : sonic-net/sonic-utilities#1355 sonic-net/sonic-buildimage#6444 What I did Added new option for "counterpoll" util Why I did it Add appropriate code to counterpoll/main.py How I verified it admin@arc-switch1041:~$ counterpoll pg-drop enable --> enable new counter admin@arc-switch1041:~$ counterpoll show --> check new PG_DROP_STAT counter status check counters admin@arc-switch1041:~$ redis-cli -n 2 127.0.0.1:6379[2]> HGETALL COUNTERS:oid:0x1a000000000062 1) "SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES" 2) "0" 3) "SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES" 4) "0" 5) "SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS" 6) "0"

…rst start (#10935) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> Backport form master Appropriate PR on master: #7735 Appropriate PR on master #6444 Why I did it PG drop counters should be enabled by default (merge from master) After "config reload" or "docker swss restart" all counters were enabled even if they were disabled before How I did it 1)Add PG drop counter enable option to dockers/docker-orchagent/enable_counters.py 2) Check if entry already exist before set default values How to verify it - install image and run counterpoll show CLI command and then you will see PG_STAT_DROP enabled - Disable few counters counterpoll pg-drop disable counterpoll port disable - Save and reload config save config reload - Check enable status

…er in counterpoll utility (#1355) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on: sonic-net/sonic-buildimage#6444 sonic-net/sonic-swss#1600 - What I did Added new option for "counterpoll" utility - How I did it Enhance counterpoll utility for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS Add new CLI command and extend the show command. - How to verify it To test it use QoS test. run the pfcxontest and Pfcxofftest, drop can be triggered in either of the test. It runs in ptf32 topo and requires RPC image. admin@arc-switch1041:~$ counterpoll pg-drop enable --> to enable the new counter admin@arc-switch1041:~$ counterpoll show --> check new INGRESS_PG_STAT_DROP counter status

Enable SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter by def…

0fb924a

…ault Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

ayurkiv-nvda force-pushed the enable_pg_stat_drop branch from 70efa75 to 0fb924a Compare January 14, 2021 14:12

This was referenced Jan 15, 2021

Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group sonic-net/sonic-swss#1600

Merged

Add new CLI for PG drop counters part of counterpoll utility sonic-net/sonic-utilities#1355

Merged

liat-grozovik requested a review from neethajohn January 19, 2021 15:06

liat-grozovik changed the title ~~Enable SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter by default~~ Enable PG drop counters by default Jan 20, 2021

liat-grozovik approved these changes Jan 20, 2021

View reviewed changes

neethajohn approved these changes Jan 26, 2021

View reviewed changes

ayurkiv-nvda requested a review from lguohan as a code owner February 6, 2021 20:29

liat-grozovik approved these changes Feb 17, 2021

View reviewed changes

liat-grozovik added the Request for 202012 Branch label Feb 17, 2021

lguohan merged commit bf83b6c into sonic-net:master Feb 17, 2021

neethajohn added the Request for 201911 Branch label Feb 17, 2021

yxieca added the Included in 202012 Branch label Feb 23, 2021

yxieca pushed a commit that referenced this pull request Feb 23, 2021

Enable SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter by def…

569686e

…ault (#6444) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021

Enable SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter by def…

3e5b9b8

…ault (sonic-net#6444) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

ayurkiv-nvda mentioned this pull request May 19, 2022

Enable PG drop counters by default ayurkiv-nvda/sonic-buildimage#18

Closed

6 tasks

ayurkiv-nvda mentioned this pull request May 26, 2022

Enable PG drop counters by default, set default values only on the first start #10935

Merged

6 tasks

ayurkiv-nvda deleted the enable_pg_stat_drop branch May 30, 2023 21:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable PG drop counters by default #6444

Enable PG drop counters by default #6444

ayurkiv-nvda commented Jan 14, 2021 •

edited by liat-grozovik

Loading

ayurkiv-nvda commented Jan 14, 2021

ayurkiv-nvda commented Jan 15, 2021

volodymyrsamotiy commented Jan 15, 2021

ayurkiv-nvda commented Jan 16, 2021

liat-grozovik commented Jan 19, 2021

liat-grozovik commented Jan 27, 2021

azure-pipelines bot commented Jan 27, 2021

liat-grozovik commented Jan 28, 2021

azure-pipelines bot commented Jan 28, 2021

neethajohn commented Feb 16, 2021

azure-pipelines bot commented Feb 16, 2021

liat-grozovik commented Feb 17, 2021

azure-pipelines bot commented Feb 17, 2021

abdosi commented Feb 19, 2021

liat-grozovik commented Feb 19, 2021 via email

bluecmd commented Apr 13, 2021

neethajohn commented Apr 13, 2021

Enable PG drop counters by default #6444

Enable PG drop counters by default #6444

Conversation

ayurkiv-nvda commented Jan 14, 2021 • edited by liat-grozovik Loading

ayurkiv-nvda commented Jan 14, 2021

ayurkiv-nvda commented Jan 15, 2021

volodymyrsamotiy commented Jan 15, 2021

ayurkiv-nvda commented Jan 16, 2021

liat-grozovik commented Jan 19, 2021

liat-grozovik commented Jan 27, 2021

azure-pipelines bot commented Jan 27, 2021

liat-grozovik commented Jan 28, 2021

azure-pipelines bot commented Jan 28, 2021

neethajohn commented Feb 16, 2021

azure-pipelines bot commented Feb 16, 2021

liat-grozovik commented Feb 17, 2021

azure-pipelines bot commented Feb 17, 2021

abdosi commented Feb 19, 2021

liat-grozovik commented Feb 19, 2021 via email

bluecmd commented Apr 13, 2021

neethajohn commented Apr 13, 2021

ayurkiv-nvda commented Jan 14, 2021 •

edited by liat-grozovik

Loading