[build arm] fix sonic-slave-buster build break #6469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the sonic-slave-buster docker container, the node.js package is installed to meet the requirements of the Azure DevOPs pipleline build. Recently this install of node.js has been failing as described within Sonic issue sonic-net#6445. This commit fixes that build break by upgrading the sonic-slave-buster build to install version 14.x of node.js which is the current LTS version for buster.
lguohan
reviewed
Jan 15, 2021
| @@ -484,7 +484,8 @@ RUN pip3 install git+https://github.com/aristanetworks/swi-tools.git@bead66bf261 | |||
|
|
|||
| {% if CONFIGURED_ARCH != "amd64" -%} | |||
| # Install node.js for azure pipeline | |||
| RUN apt-get install -y node.js | |||
| RUN curl -sL https://deb.nodesource.com/setup_14.x | bash - | |||
| RUN apt-get install -y nodejs | |||
There was a problem hiding this comment.
i do not understand what caused the build failure?
lguohan
approved these changes
Jan 17, 2021
lguohan
pushed a commit
that referenced
this pull request
Jan 21, 2021
When building the sonic-slave-buster docker container, the node.js package is installed to meet the requirements of the Azure DevOPs pipleline build. Recently this install of node.js has been failing. This commit fixes that build break by upgrading the sonic-slave-buster build to install version 14.x of node.js which is the current LTS version for buster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the sonic-slave-buster docker container, the node.js package is
installed to meet the requirements of the Azure DevOPs pipleline
build. Recently this install of node.js has been failing as described within
Sonic issue #6445. This commit fixes that build break by upgrading the
sonic-slave-buster build to install version 14.x of node.js which is the
current LTS version for buster.
Resolves issue #6445
- Why I did it
The armhf build is broken.
- How I did it
Update the node.js version within sonic-slave-buster to avoid this build break
- How to verify it
Build sonic-slave-buster for the armhf platform
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)