[device/accton][as7816-64x] Fix memory leakage on accton fan monitor #6529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: roy_lee <roy_lee@edge-core.com>
|
@roylee123: These changes were already merged in #6168, correct? You just want that PR cherry-picked to 201911 and 202006? If so, we can add the appropriate labels to the other PR. |
|
Yes, please. |
|
@roylee123: I have added the labels to #6168, and I am closing this PR, as it is not applicable. Feel free to add comments to the original PR to continue any discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is duplicated from #6168, for proposing it to be merged into branch 201911 and 202006.
Signed-off-by: roy_lee roy_lee@edge-core.com
Why I did it
It's been reported that accton fan monitor process keeps consuming memory after few days.
The amount of memory occupied increases in linear and never leased.
How I did it
Just move declaration of thermal and fan object outside the loop.
How to verify it
Just put in on for more than 5 days, check if the memory of accton fan montor increases.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Just move declaration of thermal and fan object outside the loop.