Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[barefoot][platform] Fix sonic-platform host installation #6696

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

vboykox
Copy link
Member

@vboykox vboykox commented Feb 5, 2021

Signed-off-by: Volodymyr Boyko volodymyrx.boiko@intel.com

- Why I did it
prerm is needed for platform modules package to be properly removed.
- How I did it
Added prerm to remove installed in postinst wheel packages.
- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
@vboykox vboykox requested a review from lguohan as a code owner February 5, 2021 19:28
@vboykox
Copy link
Member Author

vboykox commented Feb 5, 2021

@akokhan

@vboykox
Copy link
Member Author

vboykox commented Feb 5, 2021

@jleveque

@jleveque
Copy link
Contributor

jleveque commented Feb 6, 2021

@vboykox: Just curious under what circumstances it is necessary to remove the packages first. At the time the platform modules are installed, there should be no sonic-platform package installed.

@vboykox
Copy link
Member Author

vboykox commented Feb 6, 2021

@jleveque Actually lazy installs are installed/purged during build to install all dependencies.
The package needs to have corresponding to postinst removal logic

@jleveque jleveque merged commit 3f2a493 into sonic-net:master Feb 6, 2021
lguohan pushed a commit that referenced this pull request Feb 7, 2021
prerm is needed for platform modules package to be properly removed.
Added prerm to remove installed in postinst wheel packages.

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants