Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform] Update path to udevprefix.conf file #6779

Merged
merged 1 commit into from
Feb 14, 2021
Merged

[platform] Update path to udevprefix.conf file #6779

merged 1 commit into from
Feb 14, 2021

Conversation

jleveque
Copy link
Contributor

Why I did it

sonic-net/sonic-utilities#1431 changes the path to the udevprefix.conf file. The file previously inappropriately resided in the <platform>/plugins/ directory. That directory is reserved for now-deprecated Python platform plugins, and will be removed in the near future.

How I did it

Update all references to udevprefix.conf to reflect the new path, directly under the <platform>/ directory

Note that this PR requires sonic-net/sonic-utilities#1431. For the master branch, this means that this PR should be merged at the same time as the sonic-utilities submodule update here: #6777. For the 202012 branch, this change should be cherry-picked along with an updated 202012 branch of sonic-utilities which includes the respective commit there.

How to verify it

Ensure the udevprefix.conf is now found under the <platform>/ directory

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

@lguohan lguohan merged commit c651fbc into sonic-net:master Feb 14, 2021
@jleveque jleveque deleted the change_udevconf_path branch February 14, 2021 20:30
@lguohan
Copy link
Collaborator

lguohan commented Feb 14, 2021

@jleveque , how is this change tested? have you tried this on e1031 box?
@Blueve for awareness, this could potentially affect e1031 c0.

@jleveque
Copy link
Contributor Author

@jleveque , how is this change tested? have you tried this on e1031 box?
@Blueve for awareness, this could potentially affect e1031 c0.

The changes were not tested on an e1031 box. However, I did test the isolated changes on another device and ensured that this script now creates the udevprefix.conf file in the <platform> directory and that the consutil changes now cause it to look for the file in that directory. Therefore the changes should be seamless.

daall pushed a commit that referenced this pull request Feb 16, 2021
sonic-net/sonic-utilities#1431 changes the path to the udevprefix.conf file. The file previously inappropriately resided in the <platform>/plugins/ directory. That directory is reserved for now-deprecated Python platform plugins, and will be removed in the near future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants