[yang_models]: Update extension yang and types yang with new yang ext… #6861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensions and types respectively.
|
|
lguohan
reviewed
Feb 25, 2021
lguohan
reviewed
Feb 25, 2021
lguohan
reviewed
Feb 25, 2021
lguohan
reviewed
Feb 25, 2021
rathnasabapathyv
previously approved these changes
Mar 16, 2021
prvattem
reviewed
Mar 16, 2021
mhampasagar
previously approved these changes
Mar 18, 2021
rathnasabapathyv
previously approved these changes
Mar 18, 2021
prvattem
previously approved these changes
Mar 18, 2021
|
retest this please |
|
retest |
|
retest this please |
|
@lguohan Can you please trigger the retest of this please? |
praveen-li
suggested changes
May 27, 2021
|
BRCM team will handle this. Rajesh Velamakanni. |
|
Guohan will create a new PR for J2 template usage, then team will come back to revisit this one to proceed. |
|
@lguohan can you please link the J2 template PR to this one ? Thanks. |
|
@lguohan will raise the template PR by next meeting. |
5 tasks
|
template PR is linked, but see build failure which Guohan is checking. |
Sonic-mgmt-common already has CVL specific extensions. External yangs generated from templates will be copied to sonic-mgmt-common repo.
…ang j2 file to yang-template directory.
|
Mayank will mark the addressed comments as resolved, then reviewers will move forward |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 6861 in repo Azure/sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lguohan
approved these changes
Nov 20, 2021
praveen-li
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ensions and types respectively.
Why I did it
Added new sonic yang extensions and new yang type definitions.
How I did it
Updated new yang extensions in sonic-extension.yang. Updated new yang types in sonic-types.yang.
How to verify it
These are just new extensions and type definitions. No verification required.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Added new yang extensions and yang type definitions.
A picture of a cute animal (not mandatory but encouraged)