Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201811][sonic-config-engine] Parse AutoNegotiation element from LinkMetadata section of minigraph file #7048

Merged
merged 1 commit into from
Mar 18, 2021
Merged

[201811][sonic-config-engine] Parse AutoNegotiation element from LinkMetadata section of minigraph file #7048

merged 1 commit into from
Mar 18, 2021

Conversation

jleveque
Copy link
Contributor

Backport of #7031 to the 201811 branch

Why I did it

To enable parsing the AutoNegotiation element from the LinkMetadata section of minigraph file

How I did it

Parse the value AutoNegotiation element from the LinkMetadata section of minigraph file. If the element is present, an autoneg key will be added to the port in the PORT table of Config DB with a value of either 0 or 1

If an autoneg value is present in port_config.ini, the value from the minigraph will take precedence, overriding that value.

Also remove AutoNegotiation and EnableAutoNegotiation elements from the DeviceInfo section, as we will use this data in the LinkMetadata section to determine whether to enable auto-negotiation for a port.

How to verify it

Added unit tests to validate the behavior described above

@jleveque jleveque self-assigned this Mar 13, 2021
@lguohan
Copy link
Collaborator

lguohan commented Mar 16, 2021

can you check the build failure?

@jleveque jleveque marked this pull request as ready for review March 16, 2021 23:22
@jleveque jleveque requested a review from lguohan March 16, 2021 23:22
@jleveque
Copy link
Contributor Author

jleveque commented Mar 16, 2021

All checks have now passed except LGTM, which is having trouble locating a commit :/

I believe this PR is good to merge.

@jleveque jleveque merged commit 93fbb8f into sonic-net:201811 Mar 18, 2021
@jleveque jleveque deleted the minigraph_parse_autoneg_201811 branch March 18, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants