Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911][Monit] Monitor critical processes in radv and dhcp_relay containers. #7340

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

yozhao101
Copy link
Contributor

Signed-off-by: Yong Zhao yozhao@microsoft.com

Why I did it

This PR aims to monitor critical processes in router advertiser and dhcp_relay containers by Monit.

How I did it

Router advertiser container only ran on T0 device and the T0 device should have at least one VLAN interface
which was configured an IPv6 address. At the same time, router advertiser container will not run on devices of which
the deployment type is 8.

As such, I created a service which will dynamically generate Monit configuration file of router advertiser from a
template.

Similarly Monit configuration file of dhcp_relay was also generated from a template since the number of dhcrelay process in dhcp_relay container is depended on number of VLANs.

How to verify it

I verified this implementation on a DuT.

Which release branch to backport (provide reason below if selected)

  • 201811
  • [x ] 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
service file.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
rules/docker-dhcp-relay.mk Outdated Show resolved Hide resolved
rules/docker-router-advertiser.mk Outdated Show resolved Hide resolved
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
@yozhao101 yozhao101 merged commit 528543b into sonic-net:201911 Apr 16, 2021
@rlhui
Copy link
Contributor

rlhui commented Apr 16, 2021

could we please paste what's the corresponding sonic-mgmt test case for this?

@yozhao101
Copy link
Contributor Author

could we please paste what's the corresponding sonic-mgmt test case for this?

I am working on the PR of pytest script and will paste the link of PR later.

@yozhao101 yozhao101 deleted the monitor_radv_dhcp branch April 16, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants