Replace swsssdk.ConfigDBConnector and SonicDBConfig with swsscommon implementation in sonic-py-common #7655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
added a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
May 21, 2021
…common classes (#187) #### Description Existing test will mix true swsscommon package with the mocked one in sonic_py_common #### Motivation and Context This is blocking sonic-net/sonic-buildimage#7655 #### How Has This Been Tested? Unit test
qiluo-msft
added a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
May 24, 2021
…chassis (#188) #### Description Following #187 to fix the same issue with other packages #### Motivation and Context This is blocking sonic-net/sonic-buildimage#7655 #### How Has This Been Tested? Unit test
qiluo-msft
force-pushed
the
qiluo/swsscommon
branch
from
7cd811d
to
fca0134
Compare
qiluo-msft
commented
Jun 2, 2021
| SonicDBConfig.load_sonic_global_db_config() | ||
| config_db = ConfigDBConnector(namespace=namespace) | ||
| swsscommon.SonicDBConfig.load_sonic_global_db_config() | ||
| config_db = swsscommon.ConfigDBConnector(namespace=namespace) |
There was a problem hiding this comment.
This change will lead to some runtime error message. Still investigating...
admin@sonic:~$ sudo config load_minigraph
Warning: failed to retrieve PORT table from ConfigDB!
Traceback (most recent call last):
File "/usr/local/bin/config", line 8, in <module>
sys.exit(config())
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 764, in __call__
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 1134, in invoke
Command.invoke(self, ctx)
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.7/dist-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/config/main.py", line 913, in config
SonicDBConfig.initialize()
RuntimeError: SonicDBConfig already initialized
andywongarista
pushed a commit
to andywongarista/sonic-platform-daemons
that referenced
this pull request
Jun 30, 2021
…common classes (sonic-net#187) #### Description Existing test will mix true swsscommon package with the mocked one in sonic_py_common #### Motivation and Context This is blocking sonic-net/sonic-buildimage#7655 #### How Has This Been Tested? Unit test
andywongarista
pushed a commit
to andywongarista/sonic-platform-daemons
that referenced
this pull request
Jun 30, 2021
…chassis (sonic-net#188) #### Description Following sonic-net#187 to fix the same issue with other packages #### Motivation and Context This is blocking sonic-net/sonic-buildimage#7655 #### How Has This Been Tested? Unit test
qiluo-msft
force-pushed
the
qiluo/swsscommon
branch
from
65985c4
to
5e0b346
Compare
qiluo-msft
force-pushed
the
qiluo/swsscommon
branch
from
5e0b346
to
e643c4c
Compare
|
azp run |
|
/azp run |
|
Pull request contains merge conflicts. |
|
This PR closed, I will continue this work with another PR: #10099 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
swsssdk will be deprecated. Use swsscommon instead.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)