Add port speed configuration #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
reviewed
Jul 6, 2017
| @@ -38,7 +38,7 @@ fast_reboot | |||
|
|
|||
| HWSKU=`sonic-cfggen -m /etc/sonic/minigraph.xml -v minigraph_hwsku` | |||
|
|
|||
| SWSSCONFIG_ARGS="00-copp.config.json ipinip.json mirror.json " | |||
| SWSSCONFIG_ARGS="00-copp.config.json ipinip.json mirror.json ports.json " | |||
There was a problem hiding this comment.
if the port speed is configured here, what's the default port speed? what about adding port speed to port_config.ini file as a separate column?
There was a problem hiding this comment.
In comments to the design @lguohan suggested to make port speed mandatory in the minigraph. If for some reason it is not specified, switch will remain with the value from the SAI profile.
andriymoroz-mlnx
force-pushed
the
port_speed
branch
from
e59ba1e
to
965b5fb
Compare
Conflicts: platform/mellanox/mlnx-sai.mk
lguohan
approved these changes
Aug 9, 2017
|
I revert this commit from master. minigraph parsing logic need unit test. |
lguohan
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Feb 16, 2019
swss * a6d60f2 2019-02-15 | Create egress ACL table group during the PFCWD stats list installment (sonic-net#787) (HEAD, origin/master, origin/HEAD) [Wenda Ni] * 52de963 2019-02-15 | [fpmsyncd] Add VNET routes support (sonic-net#772) [Wei Bai] * d27f49e 2019-02-13 | Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABLE_TABLE (sonic-net#786) [Jipan Yang] * 6363985 2019-02-08 | [vstest]: Potential fix for timing issue in warm_reboot's routing UT (sonic-net#788) [Rodny Molina] * 6d5424d 2019-02-07 | VNet/Vxlan delete handling (sonic-net#766) [Prince Sunny] * d680ce2 2019-02-07 | [neighsyncd] increase neighbor syncd restore timeout to 110 seconds (sonic-net#745) [Ying Xie] * b78cc8d 2019-02-01 | support 8 lanes for a physical port (sonic-net#778) [lguohan] * 73b620c 2019-02-01 | Increase the watermark polling interval to 10s (sonic-net#777) [Wenda Ni] * a2b987b 2019-02-01 | [vstest]: fix test_speed.py (sonic-net#780) [lguohan] * cef4bd0 2019-02-01 | [vstest]: fix test_port_an_warm.py test (sonic-net#779) [lguohan] * 9f20eda 2019-02-01 | fix a unstable swss egress acl test (sonic-net#776) [Kebo Liu] * 316ae6c 2019-01-30 | portsorch ports init done flag should means buffer, autoneg, speed, m… (sonic-net#747) [Jipan Yang] * 4280036 2019-01-30 | [teammgrd] Fix inconsistent port admin status (sonic-net#755) [Jipan Yang] * cf12bdf 2019-01-30 | Remove AclTableGroup upon removal of port/lag/vlan (sonic-net#751) [Jipan Yang] * 5779c1a 2019-01-29 | [aclorch] Remove L4 port range support limitation on egress ACL table and add new SWSS virtual test. (sonic-net#741) [Kebo Liu] * 36e85eb 2019-01-29 | On a routing vlan, the neighbor entry in the /31 subnet is not added to hardware (sonic-net#771) [Kiran Kumar Kella] * 882ccc6 2019-01-24 | [vnetorch] Change logic for adding VNet interface (sonic-net#761) [Marian Pritsak] * f637557 2019-01-25 | [vrfmgrd] Fix VRF is not set to VRF_TABLE in APP_DB correctly (sonic-net#768) [yorke] * e84a6ab 2019-01-24 | use sai_stat_id_t for new SAI header file (sonic-net#769) [lguohan] sairedis * d685e35 2019-02-15 | Add support for fdb_event MOVE and check fdb event oids (sonic-net#420) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * 2b91013 2019-02-15 | [vslib] add missing port attributes for virtual switch (sonic-net#419) [Stepan Blyshchak] * dcc8688 2019-02-14 | Add more specific logic for ingress ACL and buffer profile (sonic-net#421) [Kamil Cudnik] * c0b39ea 2019-02-12 | Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABLE_TABLE (sonic-net#418) [Jipan Yang] * ab35dfa 2019-02-11 | Add support for vlan tagged frames in virtual switch (sonic-net#417) [Kamil Cudnik] * 145ea44 2019-02-02 | [flex counter] handle router interface stats (sonic-net#410) [Mykola F] * c03d639 2019-02-02 | Add more information on failed map sizes (sonic-net#416) [Kamil Cudnik] * 29f1e3c 2019-01-31 | Update SAI pointer (sonic-net#414) [Marian Pritsak] * c0a948d 2019-01-30 | Add WRED specific comparison logic (sonic-net#413) [Kamil Cudnik] * 1b6a661 2019-01-24 | install SAI extension header files into /usr/include/sai (sonic-net#412) [lguohan] * 849525a 2019-01-24 | Initialize notification queue pointer before switch create (sonic-net#411) [Kamil Cudnik] * 02d92f1 2019-01-23 | Add log info for not matching SG/IPG/QUEUES (sonic-net#409) [Kamil Cudnik] * 8793562 2019-01-18 | Update SAI pointer to latest master (sonic-net#408) [Marian Pritsak] swss-common * ec04a5a 2019-02-14 | Add support for WarmStart::setDataCheckState() (sonic-net#242) [Jipan Yang] * 56bd73f 2019-02-13 | Force only supported commands on consumer table (sonic-net#261) [Kamil Cudnik] * 414de0f 2019-02-12 | Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABLE_TABLE (sonic-net#260) [Jipan Yang] * 88de725 2019-02-05 | [pyext] enable types in stdint.h (sonic-net#259) [Ying Xie] * f457ae8 2019-02-05 | Optimized ProducerStateTable set/del notification processing to avoid… (sonic-net#257) [Jipan Yang] * e5286fd 2019-01-30 | [rif counters] Rif counter schema update (sonic-net#256) [Mykola F] sonic-utilities * b44b462 2019-02-14 | Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABL… (sonic-net#458) (HEAD, origin/master, origin/HEAD) [Jipan Yang] * e856b8b 2019-02-11 | [aclshow] output only counters per table/rule (sonic-net#442) [Roman Kachur] Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
Feb 16, 2019
…g Broadcom SAI build (#2488) * [Broadcom SAI] upgrade Broadcom SAI to 3.3.4.3m-3 This is SAI 3.3.4.3m-3 compiled with SAI header file at commit ID 6ad3382217ec22f64cd268faefcbc2ff7caba4fd of SAI repo. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * change libsaithrift version to 0.9.4 Signed-off-by: Guohan Lu <gulv@microsoft.com> * [submodule]: update swss, sairedis, swss-common, sonic-utilities swss * a6d60f2 2019-02-15 | Create egress ACL table group during the PFCWD stats list installment (#787) (HEAD, origin/master, origin/HEAD) [Wenda Ni] * 52de963 2019-02-15 | [fpmsyncd] Add VNET routes support (#772) [Wei Bai] * d27f49e 2019-02-13 | Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABLE_TABLE (#786) [Jipan Yang] * 6363985 2019-02-08 | [vstest]: Potential fix for timing issue in warm_reboot's routing UT (#788) [Rodny Molina] * 6d5424d 2019-02-07 | VNet/Vxlan delete handling (#766) [Prince Sunny] * d680ce2 2019-02-07 | [neighsyncd] increase neighbor syncd restore timeout to 110 seconds (#745) [Ying Xie] * b78cc8d 2019-02-01 | support 8 lanes for a physical port (#778) [lguohan] * 73b620c 2019-02-01 | Increase the watermark polling interval to 10s (#777) [Wenda Ni] * a2b987b 2019-02-01 | [vstest]: fix test_speed.py (#780) [lguohan] * cef4bd0 2019-02-01 | [vstest]: fix test_port_an_warm.py test (#779) [lguohan] * 9f20eda 2019-02-01 | fix a unstable swss egress acl test (#776) [Kebo Liu] * 316ae6c 2019-01-30 | portsorch ports init done flag should means buffer, autoneg, speed, m… (#747) [Jipan Yang] * 4280036 2019-01-30 | [teammgrd] Fix inconsistent port admin status (#755) [Jipan Yang] * cf12bdf 2019-01-30 | Remove AclTableGroup upon removal of port/lag/vlan (#751) [Jipan Yang] * 5779c1a 2019-01-29 | [aclorch] Remove L4 port range support limitation on egress ACL table and add new SWSS virtual test. (#741) [Kebo Liu] * 36e85eb 2019-01-29 | On a routing vlan, the neighbor entry in the /31 subnet is not added to hardware (#771) [Kiran Kumar Kella] * 882ccc6 2019-01-24 | [vnetorch] Change logic for adding VNet interface (#761) [Marian Pritsak] * f637557 2019-01-25 | [vrfmgrd] Fix VRF is not set to VRF_TABLE in APP_DB correctly (#768) [yorke] * e84a6ab 2019-01-24 | use sai_stat_id_t for new SAI header file (#769) [lguohan] sairedis * d685e35 2019-02-15 | Add support for fdb_event MOVE and check fdb event oids (#420) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * 2b91013 2019-02-15 | [vslib] add missing port attributes for virtual switch (#419) [Stepan Blyshchak] * dcc8688 2019-02-14 | Add more specific logic for ingress ACL and buffer profile (#421) [Kamil Cudnik] * c0b39ea 2019-02-12 | Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABLE_TABLE (#418) [Jipan Yang] * ab35dfa 2019-02-11 | Add support for vlan tagged frames in virtual switch (#417) [Kamil Cudnik] * 145ea44 2019-02-02 | [flex counter] handle router interface stats (#410) [Mykola F] * c03d639 2019-02-02 | Add more information on failed map sizes (#416) [Kamil Cudnik] * 29f1e3c 2019-01-31 | Update SAI pointer (#414) [Marian Pritsak] * c0a948d 2019-01-30 | Add WRED specific comparison logic (#413) [Kamil Cudnik] * 1b6a661 2019-01-24 | install SAI extension header files into /usr/include/sai (#412) [lguohan] * 849525a 2019-01-24 | Initialize notification queue pointer before switch create (#411) [Kamil Cudnik] * 02d92f1 2019-01-23 | Add log info for not matching SG/IPG/QUEUES (#409) [Kamil Cudnik] * 8793562 2019-01-18 | Update SAI pointer to latest master (#408) [Marian Pritsak] swss-common * ec04a5a 2019-02-14 | Add support for WarmStart::setDataCheckState() (#242) [Jipan Yang] * 56bd73f 2019-02-13 | Force only supported commands on consumer table (#261) [Kamil Cudnik] * 414de0f 2019-02-12 | Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABLE_TABLE (#260) [Jipan Yang] * 88de725 2019-02-05 | [pyext] enable types in stdint.h (#259) [Ying Xie] * f457ae8 2019-02-05 | Optimized ProducerStateTable set/del notification processing to avoid… (#257) [Jipan Yang] * e5286fd 2019-01-30 | [rif counters] Rif counter schema update (#256) [Mykola F] sonic-utilities * b44b462 2019-02-14 | Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABL… (#458) (HEAD, origin/master, origin/HEAD) [Jipan Yang] * e856b8b 2019-02-11 | [aclshow] output only counters per table/rule (#442) [Roman Kachur] Signed-off-by: Guohan Lu <gulv@microsoft.com> * [mlnx] update mellanox sai Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Feb 21, 2019
Submodule src/sonic-sairedis d57222a..54b02a1: > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420) > [vslib] add missing port attributes for virtual switch (sonic-net#419) Submodule src/sonic-swss 584490c..62e2a20: > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759) > [portsorch] Change speed set flow (sonic-net#764) > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787) Submodule src/sonic-swss-common 286ef34..2592b0c: > Add support for WarmStart::setDataCheckState() (sonic-net#242) Submodule src/sonic-utilities b44b462..d409987: > [sonic_installer] Improve error handling (sonic-net#460) > [clock] sync os time to CMOS before rebooting (sonic-net#465) > [intfstat] add intfstat script to output RIF counters (sonic-net#439) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Feb 22, 2019
…2594) * [201811 submodules] advance sairedis, swss, swss-common, utilities Submodule src/sonic-sairedis d57222a..54b02a1: > Add support for fdb_event MOVE and check fdb event oids (#420) > [vslib] add missing port attributes for virtual switch (#419) Submodule src/sonic-swss 584490c..62e2a20: > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (#759) > [portsorch] Change speed set flow (#764) > Create egress ACL table group during the PFCWD stats list installment (#787) Submodule src/sonic-swss-common 286ef34..2592b0c: > Add support for WarmStart::setDataCheckState() (#242) Submodule src/sonic-utilities b44b462..d409987: > [sonic_installer] Improve error handling (#460) > [clock] sync os time to CMOS before rebooting (#465) > [intfstat] add intfstat script to output RIF counters (#439) Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [201811 utilties] add 201811 branch for sonic-utilities repo Submodule src/sonic-utilities d409987...ff1448c: > [sonic_installer] Improve error handling (#460) > [clock] sync os time to CMOS before rebooting (#465) < [sonic_installer] Improve error handling (#460) < [clock] sync os time to CMOS before rebooting (#465) < [intfstat] add intfstat script to output RIF counters (#439) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…onic-net#2594) * [201811 submodules] advance sairedis, swss, swss-common, utilities Submodule src/sonic-sairedis d57222a..54b02a1: > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420) > [vslib] add missing port attributes for virtual switch (sonic-net#419) Submodule src/sonic-swss 584490c..62e2a20: > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759) > [portsorch] Change speed set flow (sonic-net#764) > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787) Submodule src/sonic-swss-common 286ef34..2592b0c: > Add support for WarmStart::setDataCheckState() (#242) Submodule src/sonic-utilities b44b462..d409987: > [sonic_installer] Improve error handling (sonic-net#460) > [clock] sync os time to CMOS before rebooting (sonic-net#465) > [intfstat] add intfstat script to output RIF counters (sonic-net#439) Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [201811 utilties] add 201811 branch for sonic-utilities repo Submodule src/sonic-utilities d409987...ff1448c: > [sonic_installer] Improve error handling (sonic-net#460) > [clock] sync os time to CMOS before rebooting (sonic-net#465) < [sonic_installer] Improve error handling (sonic-net#460) < [clock] sync os time to CMOS before rebooting (sonic-net#465) < [intfstat] add intfstat script to output RIF counters (sonic-net#439) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…onic-net#2594) * [201811 submodules] advance sairedis, swss, swss-common, utilities Submodule src/sonic-sairedis d57222a..54b02a1: > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420) > [vslib] add missing port attributes for virtual switch (sonic-net#419) Submodule src/sonic-swss 584490c..62e2a20: > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759) > [portsorch] Change speed set flow (sonic-net#764) > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787) Submodule src/sonic-swss-common 286ef34..2592b0c: > Add support for WarmStart::setDataCheckState() (#242) Submodule src/sonic-utilities b44b462..d409987: > [sonic_installer] Improve error handling (sonic-net#460) > [clock] sync os time to CMOS before rebooting (sonic-net#465) > [intfstat] add intfstat script to output RIF counters (sonic-net#439) Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [201811 utilties] add 201811 branch for sonic-utilities repo Submodule src/sonic-utilities d409987...ff1448c: > [sonic_installer] Improve error handling (sonic-net#460) > [clock] sync os time to CMOS before rebooting (sonic-net#465) < [sonic_installer] Improve error handling (sonic-net#460) < [clock] sync os time to CMOS before rebooting (sonic-net#465) < [intfstat] add intfstat script to output RIF counters (sonic-net#439) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
…onic-net#2594) * [201811 submodules] advance sairedis, swss, swss-common, utilities Submodule src/sonic-sairedis d57222a..54b02a1: > Add support for fdb_event MOVE and check fdb event oids (sonic-net#420) > [vslib] add missing port attributes for virtual switch (sonic-net#419) Submodule src/sonic-swss 584490c..62e2a20: > [fdborch] Store vlan id of FDB entry instead of port pvid into stateD… (sonic-net#759) > [portsorch] Change speed set flow (sonic-net#764) > Create egress ACL table group during the PFCWD stats list installment (sonic-net#787) Submodule src/sonic-swss-common 286ef34..2592b0c: > Add support for WarmStart::setDataCheckState() (#242) Submodule src/sonic-utilities b44b462..d409987: > [sonic_installer] Improve error handling (sonic-net#460) > [clock] sync os time to CMOS before rebooting (sonic-net#465) > [intfstat] add intfstat script to output RIF counters (sonic-net#439) Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [201811 utilties] add 201811 branch for sonic-utilities repo Submodule src/sonic-utilities d409987...ff1448c: > [sonic_installer] Improve error handling (sonic-net#460) > [clock] sync os time to CMOS before rebooting (sonic-net#465) < [sonic_installer] Improve error handling (sonic-net#460) < [clock] sync os time to CMOS before rebooting (sonic-net#465) < [intfstat] add intfstat script to output RIF counters (sonic-net#439) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
…sonic-net#787) * Create egress table group during the PFCWD stats list installment Signed-off-by: Wenda <wenni@microsoft.com> * Introduce function bindAclTableGroup() to create and bind ACL table group to a port, which can be physical, vlan, or lag Signed-off-by: Wenda <wenni@microsoft.com> * Rename function to createBindAclTableGroup() Signed-off-by: Wenda Ni <wenni@microsoft.com> * Check the validity of ACL table oid Signed-off-by: Wenda Ni <wenni@microsoft.com>
This was referenced Feb 9, 2021
lguohan
referenced
this pull request
Feb 10, 2021
Includes below commits: 13474d1 2021-02-08 [sairedis][syncd] VidManager add updateIndex method (Azure#787) be8059f 2021-02-08 [sairedis] Add get response timeout knob (Azure#774) 3663e30 2021-02-06 [syncd] Create base class SaiSwitchInterface (Azure#786) 3360b0f 2021-02-05 Reduce log level of redis channel to debug (Azure#790) 08d338a 2021-02-05 syncd: Fix profile iterator bug (Azure#789) a6377d0 2021-02-03 [ci]: use publish pipeline artifacts to publish syslog (Azure#788) Signed-off-by: liora <liora@nvidia.com>
daall
referenced
this pull request
Feb 16, 2021
Includes below commits: 13474d1 2021-02-08 [sairedis][syncd] VidManager add updateIndex method (Azure#787) be8059f 2021-02-08 [sairedis] Add get response timeout knob (Azure#774) 3663e30 2021-02-06 [syncd] Create base class SaiSwitchInterface (Azure#786) 3360b0f 2021-02-05 Reduce log level of redis channel to debug (Azure#790) 08d338a 2021-02-05 syncd: Fix profile iterator bug (Azure#789) a6377d0 2021-02-03 [ci]: use publish pipeline artifacts to publish syslog (Azure#788) Signed-off-by: liora <liora@nvidia.com>
AidanCopeland
pushed a commit
to Metaswitch/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
Will be needed for asic compare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.