[hostcfgd] Delay hostcfgd and aaastatsd for faster boot time #7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
previously approved these changes
Jun 27, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jleveque could you please provide your feedback on this PR? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jul 8, 2021
…allow 'hostcfgd' to start and configure tacas authorization. (#3741) - What is the motivation for this PR? After recent change introduced on this PR's: sonic-net/sonic-buildimage#7965 and sonic-net/sonic-buildimage#8117 'hostcfgd' will be delayed in 90 seconds. If the test will run before the daemon has started, it will fail the test. This is to align with the new change and make sure the test will pass. - How did you do it? Add a delay of 100 seconds before executing authorized commands. - How did you verify/test it? Run the test. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Aug 9, 2021
|
@lguohan @qiluo-msft This PR is approved and all checkers passed, can we proceed and merge? |
|
This PR could not cleanly cherry-pick to 202012. Please submit another PR. |
@qiluo-msft there was already a PR for 202012 and it is merged. |
judyjoseph
pushed a commit
that referenced
this pull request
Aug 25, 2021
#### Why I did it hostcfgd is starting at the same time as 'create_switch' method is called on orchagent process. This introduce a degradation on the function execution time which eventually cause the fast-boot flow and a boot scenarion in general to run slower (~6 seconds). This change will delay the start time of this daemon. The aaastatsd will delay as well since it has a dependency on hostcfgd, so it is required to delay both. 90 seconds determined as the maximum allowed downtime for control plane to come back up on fast-boot flow. #### How I did it Add two timers for hostcfgd and aaastatsd services in order to delay the startup of these services. #### How to verify it Install an image with this change and observe the daemons start 90 seconds after the system boot.
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Sep 8, 2021
…onic-net#7965)" This reverts commit 76d5223.
5 tasks
lguohan
added a commit
that referenced
this pull request
Sep 8, 2021
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Sep 12, 2021
…ot time (sonic-net#7965)" (sonic-net#8705)" This reverts commit f4dea87.
yxieca
added a commit
that referenced
this pull request
Sep 14, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…allow 'hostcfgd' to start and configure tacas authorization. (sonic-net#3741) - What is the motivation for this PR? After recent change introduced on this PR's: sonic-net/sonic-buildimage#7965 and sonic-net/sonic-buildimage#8117 'hostcfgd' will be delayed in 90 seconds. If the test will run before the daemon has started, it will fail the test. This is to align with the new change and make sure the test will pass. - How did you do it? Add a delay of 100 seconds before executing authorized commands. - How did you verify/test it? Run the test. Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…e to hostcfgd delay on boot (sonic-net#3775) What is the motivation for this PR? After recent change introduced on this PR's: sonic-net/sonic-buildimage#7965 sonic-net/sonic-buildimage#8117 'hostcfgd' will be delayed in 90 seconds. If the test will run before the daemon has started, it will fail the test. This is to align with the new change and make sure the test will pass. Profiling the time it takes to configure tacacs after the daemon started can take time: main started -> Mon 12 Jul 2021 02:07:06 PM UTC 'tacacs_server_update' function finished -> Mon 12 Jul 2021 02:08:10 PM UTC Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
Why I did it
hostcfgd is starting at the same time as 'create_switch' method is called on orchagent process.
This introduce a degradation on the function execution time which eventually cause the fast-boot flow and a boot scenarion in general to run slower (~6 seconds).
This change will delay the start time of this daemon.
The aaastatsd will delay as well since it has a dependency on hostcfgd, so it is required to delay both.
90 seconds determined as the maximum allowed downtime for control plane to come back up on fast-boot flow.
How I did it
Add two timers for hostcfgd and aaastatsd services in order to delay the startup of these services.
How to verify it
Install an image with this change and observe the daemons start 90 seconds after the system boot.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)