Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DellEmc] Fix port lanes on alternative S5232 SKUs #8208

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

bluecmd
Copy link
Contributor

@bluecmd bluecmd commented Jul 17, 2021

Backport the fix (444cede) that was made for the default SKU
to the alternative SKUs.

Why I did it

The tenGigE1/33 and tenGigE1/34 works with the default SKU configuration, but not with the one I want to use - DellEMC-S5232f-P-25G.

How I did it

I looked at the differences between these SKUs as well as the state in bcmsh and saw that the ps output looked off when Ethernet129 was enabled.

How to verify it

  • Connect a device to one of the two 10G slots (not both)
  • Load e.g. the 25G SKU: sonic-cfggen -H -k DellEMC-S5232f-P-25G --print-data > /etc/sonic/config_db.json; reboot
  • Enable the port: sudo config int startup Ethernet129
  • Observe the port still being down: show int status | grep tenGig
  • Enable the other port: sudo config int startup Ethernet128
  • Observe the first port now being up, while the SFP module being on the wrong slot: show int status | grep tenGig.

E.g.:

admin@localhost:~$ show int status | grep tenGig
Ethernet128              128      10G   9100    N/A           tenGigE1/33  routed      up       up              N/A         N/A
Ethernet129              129      10G   9100    N/A           tenGigE1/34  routed    down       up   SFP/SFP+/SFP28         N/A

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

These are the releases the referenced bug fix was included in, but the alternative SKUs were not fixed.

Description for the changelog

  • Correct the 10G lane assignments for alternative SKUs for Dell EMC S5232F.

A picture of a cute animal (not mandatory but encouraged)

image

Backport the fix (444cede) that was made for the default SKU
to the alternative SKUs.

Signed-off-by: Christian Svensson <blue@cmd.nu>
@bluecmd bluecmd requested a review from jleveque as a code owner July 17, 2021 18:06
@bluecmd
Copy link
Contributor Author

bluecmd commented Jul 21, 2021

Ping @jleveque - is there anything I can do to help this PR along?

@lguohan lguohan merged commit 6b32f06 into sonic-net:master Jul 24, 2021
@bluecmd bluecmd deleted the bluecmd/dell-10g-mixup-master branch July 24, 2021 23:35
qiluo-msft pushed a commit that referenced this pull request Jul 27, 2021
Backport the fix (444cede) that was made for the default SKU to the alternative SKUs.

Signed-off-by: Christian Svensson <blue@cmd.nu>
judyjoseph pushed a commit that referenced this pull request Aug 7, 2021
Backport the fix (444cede) that was made for the default SKU to the alternative SKUs.

Signed-off-by: Christian Svensson <blue@cmd.nu>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…ic-net#8208)

Backport the fix (444cede) that was made for the default SKU to the alternative SKUs.

Signed-off-by: Christian Svensson <blue@cmd.nu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants