[build] Always use -j1 for libsnmp to avoid race condition #8324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Sherman <jusherma@cisco.com>
jusherma
force-pushed
the
jusherma/libtool-build
branch
from
c36050e to
d06644d
Compare
lguohan
approved these changes
Aug 4, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 5, 2021
I have been seeing intermittent (~40%) build failures with the same error described in PR #6592, even with that fix present ``` /usr/bin/ld: mibgroup/ip-forward-mib/ipCidrRouteTable/.libs/ipCidrRouteTable_interface.o: file not recognized: file truncated ... libtool: error: 'mibgroup/ip-forward-mib/inetCidrRouteTable/inetCidrRouteTable_interface.lo' is not a valid libtool object make[5]: *** [Makefile:1020: libnetsnmpmibs.la] Error 1 make[5]: *** Waiting for unfinished jobs.... ``` #### How I did it Use `-j1` for the libsnmp build regardless of the value of `$(MULTIARCH_QEMU_ENVIRON)` #### How to verify it Performed 10 builds of the libsnmp target (`target/debs/buster/libsnmp-base_5.7.3+dfsg-5_all.deb`) with and without this change. Without the change, hit the error 40% of the time. With the change did not see the error at all Signed-off-by: Justin Sherman <jusherma@cisco.com>
judyjoseph
pushed a commit
that referenced
this pull request
Aug 7, 2021
I have been seeing intermittent (~40%) build failures with the same error described in PR #6592, even with that fix present ``` /usr/bin/ld: mibgroup/ip-forward-mib/ipCidrRouteTable/.libs/ipCidrRouteTable_interface.o: file not recognized: file truncated ... libtool: error: 'mibgroup/ip-forward-mib/inetCidrRouteTable/inetCidrRouteTable_interface.lo' is not a valid libtool object make[5]: *** [Makefile:1020: libnetsnmpmibs.la] Error 1 make[5]: *** Waiting for unfinished jobs.... ``` #### How I did it Use `-j1` for the libsnmp build regardless of the value of `$(MULTIARCH_QEMU_ENVIRON)` #### How to verify it Performed 10 builds of the libsnmp target (`target/debs/buster/libsnmp-base_5.7.3+dfsg-5_all.deb`) with and without this change. Without the change, hit the error 40% of the time. With the change did not see the error at all Signed-off-by: Justin Sherman <jusherma@cisco.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…#8324) I have been seeing intermittent (~40%) build failures with the same error described in PR sonic-net#6592, even with that fix present ``` /usr/bin/ld: mibgroup/ip-forward-mib/ipCidrRouteTable/.libs/ipCidrRouteTable_interface.o: file not recognized: file truncated ... libtool: error: 'mibgroup/ip-forward-mib/inetCidrRouteTable/inetCidrRouteTable_interface.lo' is not a valid libtool object make[5]: *** [Makefile:1020: libnetsnmpmibs.la] Error 1 make[5]: *** Waiting for unfinished jobs.... ``` #### How I did it Use `-j1` for the libsnmp build regardless of the value of `$(MULTIARCH_QEMU_ENVIRON)` #### How to verify it Performed 10 builds of the libsnmp target (`target/debs/buster/libsnmp-base_5.7.3+dfsg-5_all.deb`) with and without this change. Without the change, hit the error 40% of the time. With the change did not see the error at all Signed-off-by: Justin Sherman <jusherma@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Sherman jusherma@cisco.com
Why I did it
I have been seeing intermittent (~40%) build failures with the same error described in PR #6592, even with that fix present
How I did it
Use
-j1for the libsnmp build regardless of the value of$(MULTIARCH_QEMU_ENVIRON)How to verify it
Performed 10 builds of the libsnmp target (
target/debs/buster/libsnmp-base_5.7.3+dfsg-5_all.deb) with and without this change. Without the change, hit the error 40% of the time. With the change did not see the error at allWhich release branch to backport (provide reason below if selected)
Description for the changelog
Always use -j1 for libsnmp to avoid libtool race condition
A picture of a cute animal (not mandatory but encouraged)