Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mellanox]: Move FW upgrade script to base image. #849

Merged
merged 1 commit into from
Jul 28, 2017
Merged

[mellanox]: Move FW upgrade script to base image. #849

merged 1 commit into from
Jul 28, 2017

Conversation

oleksandrivantsiv
Copy link
Collaborator

No description provided.

marian-pritsak
marian-pritsak suggested changes Jul 27, 2017
View reviewed changes
Copy link
Collaborator

@marian-pritsak marian-pritsak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean targets must be updated too # resolved

qiluo-msft
qiluo-msft reviewed Jul 27, 2017
View reviewed changes
files/build_templates/swss.service.j2
ExecStartPre=/usr/bin/mst start
ExecStartPre=/usr/bin/mlnx-fw-upgrade.sh
Copy link
Collaborator

@qiluo-msft qiluo-msft Jul 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If firmware is really upgraded, will the service restart? #Closed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to restart service. FW update procedure starts before SX kernel drivers and SDK.

@qiluo-msft
Copy link
Collaborator

exit 0

The comment is not updated.
Could you not use the 'exit 0' trick? Use a normal non-zero return value?

Refers to: platform/mellanox/mlnx-fw-upgrade.sh:52 in ed93a79. [](commit_id = ed93a795eae0eade4a9035165d40d2c04b865531, deletion_comment = False)

qiluo-msft
qiluo-msft requested changes Jul 27, 2017
View reviewed changes
Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comments.

@oleksandrivantsiv
[mellanox]: Move FW upgrade script to base image.
475f89e 
- Download files to target/files directory (instead of target/debs)
- Clean python-weels log files
@oleksandrivantsiv
Copy link
Collaborator Author

@qiluo-msft I've updated mlnx-fw-upgrade.sh script. Please review

@marian-pritsak
Copy link
Collaborator

retest this please

@qiluo-msft qiluo-msft merged commit 382d528 into sonic-net:master Jul 28, 2017
@qiluo-msft qiluo-msft mentioned this pull request Jul 29, 2017
Closed
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Mar 22, 2020
@lguohan
[submodule]: update sonic-utilities
21003db 
* d0f8091 2020-03-22 | Revert "add support for MCLAG (sonic-net#453)" (sonic-net#849) (HEAD -> master, origin/master, origin/HEAD) [lguohan]
* 6f54e8c 2020-03-22 | Revert "return list for _get_optional_services() (sonic-net#822)" (sonic-net#848) [lguohan]
* f1c79d5 2020-03-22 | return list for _get_optional_services() (sonic-net#822) (HEAD -> master, origin/master, origin/HEAD) [shine4chen]
* 28ea21a 2020-03-21 | Fix kernel panic for irq after fast-reboot (sonic-net#823) [byu343]
* 727b499 2020-03-22 | [decode-syseeprom] fix getattribute check for sime platforms (sonic-net#835) [Mykola F]
* db78cb6 2020-03-21 | Update Command Reference with sFlow section (sonic-net#841) [padmanarayana]
* 780673c 2020-03-21 | explicitly specify command with underscores (sonic-net#846) [lguohan]
* 07dc201 2020-03-21 | [db_migrator]Do DB migration for buffer pool size change on Mellanox platform (sonic-net#833) [Kebo Liu]
* 9a94955 2020-03-20 | [sonic_installer] Enable ARM64 arch (sonic-net#811) [arheneus@marvell.com]
* 92b30c2 2020-03-18 | [config]: add syslog messages to config load_minigraph/reload (sonic-net#843) [lguohan]
* 4389ffe 2020-03-17 | [intfutil] set speed to 0 when interface speed is not available (sonic-net#839) [Ying Xie]
* 45c6c68 2020-03-17 | [Mellanox] add document for thermal control related cli (sonic-net#832) [Junchao-Mellanox]
* 7105400 2020-03-12 | Add kdump support for Aboot platforms (sonic-net#824) [byu343]
* c5c5ffc 2020-03-01 | [fwutil]: Set default socket timeout for FW download to 30 sec. (sonic-net#821) [Nazarii Hnydyn]
* 81c5930 2020-03-01 | Update config/show to include PFC Watchdog commands (sonic-net#736) [Andriy Moroz]
* 66e9dfb 2020-02-28 | [MultiDB] sonic-utilities - replace redis-cli/redis-dump with sonic-db-cli/sonic-db-dump (sonic-net#810) [Dong Zhang]
* 8aea564 2020-02-24 | add support for MCLAG (sonic-net#453) [shine4chen]
* 118620f 2020-02-23 | [reboot] make sure the reboot happens even if platform reboot failed (sonic-net#819) [Ying Xie]
* 40eff82 2020-02-22 | Multi-Db changes for NAT feature. (sonic-net#818) [Akhilesh Samineni]
* a4cb4dd 2020-02-21 | [Command-Reference.md] Unify Usage statments and Examples (including sample prompts) (sonic-net#816) [Joe LeVeque]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan mentioned this pull request Mar 22, 2020
Merged
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Mar 23, 2020
@lguohan
* d0f8091 2020-03-22 | Revert "add support for MCLAG (sonic-net#453)" (…
02d73ab 
…sonic-net#849) (HEAD -> master, origin/master, origin/HEAD) [lguohan]

* 6f54e8c 2020-03-22 | Revert "return list for _get_optional_services() (sonic-net#822)" (sonic-net#848) [lguohan]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@prsunny
[vnetorch]: Fix incorrect creation flow for bitmap VNET (sonic-net#849)
eb30871 
* Initialize VNET ID before creating VNET object

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
lguohan added a commit that referenced this pull request Mar 23, 2020
@lguohan
[submodule]: update sonic-utilities (#4308)
944ff08 
* [submodule]: update sonic-utilities

* d0f8091 2020-03-22 | Revert "add support for MCLAG (#453)" (#849) (HEAD -> master, origin/master, origin/HEAD) [lguohan]
* 6f54e8c 2020-03-22 | Revert "return list for _get_optional_services() (#822)" (#848) [lguohan]
* f1c79d5 2020-03-22 | return list for _get_optional_services() (#822) (HEAD -> master, origin/master, origin/HEAD) [shine4chen]
* 28ea21a 2020-03-21 | Fix kernel panic for irq after fast-reboot (#823) [byu343]
* 727b499 2020-03-22 | [decode-syseeprom] fix getattribute check for sime platforms (#835) [Mykola F]
* db78cb6 2020-03-21 | Update Command Reference with sFlow section (#841) [padmanarayana]
* 780673c 2020-03-21 | explicitly specify command with underscores (#846) [lguohan]
* 07dc201 2020-03-21 | [db_migrator]Do DB migration for buffer pool size change on Mellanox platform (#833) [Kebo Liu]
* 9a94955 2020-03-20 | [sonic_installer] Enable ARM64 arch (#811) [arheneus@marvell.com]
* 92b30c2 2020-03-18 | [config]: add syslog messages to config load_minigraph/reload (#843) [lguohan]
* 4389ffe 2020-03-17 | [intfutil] set speed to 0 when interface speed is not available (#839) [Ying Xie]
* 45c6c68 2020-03-17 | [Mellanox] add document for thermal control related cli (#832) [Junchao-Mellanox]
* 7105400 2020-03-12 | Add kdump support for Aboot platforms (#824) [byu343]
* c5c5ffc 2020-03-01 | [fwutil]: Set default socket timeout for FW download to 30 sec. (#821) [Nazarii Hnydyn]
* 81c5930 2020-03-01 | Update config/show to include PFC Watchdog commands (#736) [Andriy Moroz]
* 66e9dfb 2020-02-28 | [MultiDB] sonic-utilities - replace redis-cli/redis-dump with sonic-db-cli/sonic-db-dump (#810) [Dong Zhang]
* 8aea564 2020-02-24 | add support for MCLAG (#453) [shine4chen]
* 118620f 2020-02-23 | [reboot] make sure the reboot happens even if platform reboot failed (#819) [Ying Xie]
* 40eff82 2020-02-22 | Multi-Db changes for NAT feature. (#818) [Akhilesh Samineni]
* a4cb4dd 2020-02-21 | [Command-Reference.md] Unify Usage statments and Examples (including sample prompts) (#816) [Joe LeVeque]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@lguohan
Revert "add support for MCLAG (sonic-net#453)" (sonic-net#849)
d0f8091 
This reverts commit 8aea564.
mssonicbld added a commit that referenced this pull request Mar 27, 2024
@mssonicbld
[submodule] Update submodule sonic-swss-common to the latest HEAD aut…
bfc689f 
…omatically (#18477)

#### Why I did it
src/sonic-swss-common
```
* afd561f - (HEAD -> master, origin/master, origin/HEAD) ASIC/SDK health event (#849) (42 seconds ago) [Stephen Sun]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marian-pritsak marian-pritsak marian-pritsak approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oleksandrivantsiv @qiluo-msft @marian-pritsak @stcheng @msftclas