[Nokia ixs7215] sfp get_name test case fix #8507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it is not quite clear if the test is correct or not, there is ongoing discussing which what index should be used, currently the thinking is that it should the use the index that is in the port_config.ini. |
|
What is the reference product code for this that uses index from port_config.ini that I can look at? -- it appears to be implemented differently by many vendors. |
|
I reviewed this PR with Prince George - his conclusion is "Your PR looks fine to me." |
prgeor
approved these changes
Aug 20, 2021
This was referenced Sep 2, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Sep 2, 2021
Account for sfputil_helper indexing being 0 based Co-authored-by: Carl Keene <keene@nokia.com>
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 7, 2021
Account for sfputil_helper indexing being 0 based Co-authored-by: Carl Keene <keene@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix for open community test test_sfp.py test_get_name
How I did it
Account for sfputil_helper indexing being 0 based
How to verify it
Run sonic-mgmt test_sfp.py test cases
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)