[202012] BRCM SAI 4.3.5.1-2 Fix BRCM SAI regression due to ACL Egress Mirroring Action capability #8682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Mirroring Action capability
gechiang
requested review from
lguohan,
bingwang-ms,
qiluo-msft,
rlhui and
vmittal-msft
vmittal-msft
approved these changes
Sep 3, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Sep 6, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The failed test has nothing to do with the BRCM SAI. will proceed with merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
BRCM SAI 4.3.5.1-1 picked up fix that address configurable counter resource fix had a regression where it also include changes to TD3 ACL Egress Mirroring Action capability that it is not supporting but claimed as capable.
This caused the Everflow Egress Mirroring testing into thinking TD3 is capable of handling it and attempted to test its functionality that resulted to ACL table programming failure.
Issue: (#8671)
How I did it
Examined the SAI changes and found the list of capability for TD3 was changed to include Egress Mirroring Action.
Removed it from the list of enums and built SAI 4.3.5.1-2 and verified that the everflow testcase now skips it due to the capability is back to correct setting (Egress Mirroring Action not there any more after the cahnge)
How to verify it
See Issue (#8671) for details on how to verify the fix.
Which release branch to backport (provide reason below if selected)
Description for the changelog
[202012] BRCM SAI 4.3.5.1-2 Fix BRCM SAI regression due to ACL Egress Mirroring Action capability
A picture of a cute animal (not mandatory but encouraged)