Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reclaim buffer] Reclaim unused buffers by applying zero buffer profiles #8768

Merged
merged 27 commits into from
Nov 29, 2021
Merged

[Reclaim buffer] Reclaim unused buffers by applying zero buffer profiles #8768

merged 27 commits into from
Nov 29, 2021

Commits on Aug 11, 2021

  1. Support zero buffer profiles 

    1. Add buffer profiles and pool definition for zero buffer profiles
   - If buffer model is static:
      - Apply normal buffer profiles to admin-up ports
      - Apply zero buffer profiles to admin-down ports
   - If buffer model is dynamic:
      - Apply normal buffer profiles to all ports
      - buffer manager will take care when a port is shutdown
2. To make code clean and reduce redundant code, extract common macros from buffer_defaults_t{0,1}.j2 of all SKUs to two common files:
    - one in Mellanox-SN2700 for single ingress pool mode
    - the other in ACS-MSN2700 for double ingress pool mode
   Those files of all other SKUs will be symbol link to the above files
3. Adjust example output file of json template for unit test

Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    6220e13 View commit details
    Browse the repository at this point in the history

  2. Fix typo and remove unused profiles 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    824c4f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Fix errors 

    Remvoe ingress_lossless_pool.xoff from generic SKU
Fix errors when inactive ports set is empty

Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    e036731 View commit details
    Browse the repository at this point in the history

  2. Remove unused comma 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    300871a View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. Fix errors 

    1. Use one item for all queues if the port is admin down
2. Fix errors in buffers_defaults_t1.j2 in 2700

Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    0c292d7 View commit details
    Browse the repository at this point in the history

  2. Add template for zero profiles in dynamic model and update buffermgrd… 

    ….sh accordingly

Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    f35ee98 View commit details
    Browse the repository at this point in the history

  3. Add unit test cases for buffer template 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    639071e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Add zero_profiles.j2 for dynamic model 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    c8f0fc8 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Generate separated items of zero profiles for queues 

    Adjust test cases accordingly.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    6b79334 View commit details
    Browse the repository at this point in the history

  2. Remove trailing spaces 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    fb75c9b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Update: pgs_to_reclaim => pgs_to_apply_zero_profile 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    c57a674 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Change field name according to HLD 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    a121fdf View commit details
    Browse the repository at this point in the history

  2. Make it possible to run vstest for zero profiles 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    6e91f49 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. Merge branch 'master' into zero-profiles-master

    @stephenxs
    stephenxs committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    2e286e1 View commit details
    Browse the repository at this point in the history

  2. Adjust files according to QoS key format change 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    fd3d328 View commit details
    Browse the repository at this point in the history

  3. Adjust buffer template for reclaiming buffer for SN3800-D100C12S2

    @stephenxs
    stephenxs committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    419bcb8 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Update Mellanox specific files to tolerance the zero port scenario 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    7de7069 View commit details
    Browse the repository at this point in the history

  2. Common buffer template to tolerance zero buffer scenario 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    ceb3ae7 View commit details
    Browse the repository at this point in the history

  3. Update common test cases for buffer template 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    805c40b View commit details
    Browse the repository at this point in the history

  4. Update mellanox specific test cases for buffer template 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    03d2fc3 View commit details
    Browse the repository at this point in the history

  5. Minimize the change in the common code 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    6ed2df7 View commit details
    Browse the repository at this point in the history

  6. Adjust Mellanox testcases 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    5b23d14 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Make j2 minigraph test a fixture 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    520257d View commit details
    Browse the repository at this point in the history

  2. Remove redundant testcases 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    31922f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Added missing file 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    9c812ff View commit details
    Browse the repository at this point in the history

  2. Move common files to another independent PR 

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    @stephenxs
    stephenxs committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    777eb8c View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Merge branch 'Azure:master' into zero-profiles

    @stephenxs
    stephenxs authored Nov 24, 2021
    Configuration menu
    Copy the full SHA
    5cce936 View commit details
    Browse the repository at this point in the history