Port speed #879

andriymoroz-mlnx · 2017-08-10T13:32:57Z

No description provided.

Conflicts: platform/mellanox/mlnx-sai.mk

lguohan · 2017-08-18T00:23:33Z

retest this please

lguohan · 2017-08-18T05:50:04Z

src/sonic-config-engine/tests/simple-sample-graph.xml

+          <Speed>1000000</Speed>
+        </a:EthernetInterface>
+      </EthernetInterfaces>
+    </DeviceInfo>


add hwsku in the deviceinfo

<HwSku>Force10-S6000</HwSku>

lguohan · 2017-08-18T05:54:56Z

src/sonic-config-engine/minigraph.py

@@ -438,6 +450,8 @@ def parse_xml(filename, platform=None, port_config_file=None):
            (u_neighbors, u_devices, _, _, _, _) = parse_png(child, hostname)
        elif child.tag == str(QName(ns, "MetadataDeclaration")):
            (syslog_servers, dhcp_servers, ntp_servers, mgmt_routes, erspan_dst, deployment_id) = parse_meta(child, hostname)
+        elif child.tag == str(QName(ns, "DeviceInfos")):
+            ethernet_interfaces = parse_deviceinfo(child, hostname)


change to parse_deviceinfo(child, hwsku)

lguohan · 2017-08-18T05:55:23Z

src/sonic-config-engine/minigraph.py

@@ -323,6 +323,17 @@ def parse_meta(meta, hname):
                    deployment_id = value
    return syslog_servers, dhcp_servers, ntp_servers, mgmt_routes, erspan_dst, deployment_id

+def parse_deviceinfo(meta, hname):


change hname to hwsku

lguohan · 2017-08-18T05:55:41Z

src/sonic-config-engine/minigraph.py

+def parse_deviceinfo(meta, hname):
+    ethernet_interfaces = []
+
+    device_info = meta.find(str(QName(ns, "DeviceInfo")))


In DeviceInfos, there are many deviceinfo. You need findall deviceinfo. and for each deviceinfo, you need to find the hwsku and only choose the hwsku that is same as hwsku.

lguohan · 2017-08-18T06:07:09Z

src/sonic-config-engine/tests/simple-sample-graph.xml

+          <EnableAutoNegotiation>true</EnableAutoNegotiation>
+          <EnableFlowControl>true</EnableFlowControl>
+          <Index>1</Index>
+          <InterfaceName>Ethernet0</InterfaceName>


-> fortyGigE0/0

lguohan

as comment

lguohan · 2017-08-22T15:36:59Z

@andriymoroz-mlnx , can you please update the sonic-swss submodule?

lguohan · 2017-08-23T11:05:16Z

merge pending on some other commits.

[vnetorch]: Use metadata matching for tunnel (sonic-net#841) [aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868) [restore_neighbors] fix failure with scapy 2.4.2 (sonic-net#862) [intfsorch] Fix bug for VRF existence check (sonic-net#882) Return 0 for CRM counter instead of None if no match (sonic-net#879) Undo skipping Vnet tests, Vrf check before enslaving (sonic-net#857) [Makefile]: Remove header files from source files (sonic-net#883) Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

[vnetorch]: Use metadata matching for tunnel (#841) [aclorch]: Add ICMP type/code match for v4/v6 (#868) [restore_neighbors] fix failure with scapy 2.4.2 (#862) [intfsorch] Fix bug for VRF existence check (#882) Return 0 for CRM counter instead of None if no match (#879) Undo skipping Vnet tests, Vrf check before enslaving (#857) [Makefile]: Remove header files from source files (#883) Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

[vnetorch]: Use metadata matching for tunnel (sonic-net#841) [aclorch]: Add ICMP type/code match for v4/v6 (sonic-net#868) [restore_neighbors] fix failure with scapy 2.4.2 (sonic-net#862) [intfsorch] Fix bug for VRF existence check (sonic-net#882) Return 0 for CRM counter instead of None if no match (sonic-net#879) Undo skipping Vnet tests, Vrf check before enslaving (sonic-net#857) [Makefile]: Remove header files from source files (sonic-net#883) Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>

* msft_github/master: [snmpagent]: Update sonic-snmpagent submodule (sonic-net#1004) [swss]: Update the ipinip.j2 template to specify the IPv4 loopback address (sonic-net#998) Change all port_config.ini column headers from 'port' to 'index' (sonic-net#1001) [docker-platform-monitor]: Remove stale fancontrol.pid file (if exists) before starting fancontrol (sonic-net#1002) [swss]: Update swss/common submodules (sonic-net#988) [snmp]: Update py-swsssdk/snmpagent submodules (sonic-net#996) [Broadcom]: Update SAI version to 3.0.3.2-5 (sonic-net#997) [Mellanox]: Update outdated MSN2410 minigraph (sonic-net#995) Add time stamp suffix to the dirty images version string (sonic-net#958) [Mellanox]: Remove FW upgrade procedure in docker (sonic-net#989) [snmp]: Update sonic-snmpagent submodule (sonic-net#986) [Broadcom]: Update SAI version to 3.0.3.2-4 (sonic-net#983) [Ingrasys]: Add Ingrasys S8900-64XC sfputil function and update submodule (sonic-net#984) [mellanox]: Update Mellanox SAI version (sonic-net#979) [Ingrasys]: Change hwmon kernel modules installation order (sonic-net#980) [Makefile] Allowing interactive session with the slave docker-container (sonic-net#903) [snmp]: Update sonic-snmpagent submodule (sonic-net#978) Disable snmpd module disk_hw, so no syslog messages about unavailable disks (sonic-net#977) [teamd]: Remove deprecated blocking logic before starting teamd (sonic-net#976) [Broadcom]: Update libsai version to 3.0.3.2-2 (sonic-net#973) [device/accton]: Add a new supported device, AS7312-54X (sonic-net#955) [sairedis]: update sairedis submodule (sonic-net#974) lacp runner will send lacp update right after it received SIGINT (sonic-net#969) [config]: Fix management interface configuration (sonic-net#966) [Broadcom]: Update OpenNSL modules (sonic-net#970) [utilities]: Update sonic-utilities (sonic-net#968) [interfaces]: Change MTU value to 9100 (sonic-net#967) Framework to plugin Organization specific scripts during ONIE Image build (sonic-net#951) Always start with Forwarding State flag set for bgpd (sonic-net#963) Update sonic-utilities to be compatible with sonic-net#942 (sonic-net#965) [swss]: Fix the command to get HWSKU with sonic-cfggen (sonic-net#964) [bgp]: Fix the deployment_id with DEVICE_METADATA (sonic-net#962) [Ingrasys] Update Ingrasys submodule for S8900-54XC (sonic-net#954) [build/onie installer] Install grub for SONiC post migration from another NOS (sonic-net#949) [syncd]: Comment out unused docker-ptf-brcm.mk [Broadcom]: Update OpenNSL/SAI version (sonic-net#959) [swss]: Move swss/common/sairedis submodule to 201709 tag [sairedis]: update sairedis submodule head (sonic-net#956) [service template] Starting new docker when HWSKU change is detected (sonic-net#946) [config] Fix an issue that bgp asn data type is not consistent (sonic-net#953) [mellanox]: Update Mellanox SAI version ansd SDK version [Ingrasys] update port_config.ini and sfputil for ingrasys platforms (sonic-net#952) [frr]: RR client support in minigraph for FRR (sonic-net#923) [configdb] Migrate minigraph configurations to DB (sonic-net#942) [devices]: Add led plugin for Arista 7060CX-32S and 7260CX3-64 (sonic-net#945) [sonic-slave]: SLAVE_TAG should be for both Dockerfile and Dockerfile.user (sonic-net#950) [github]: add templates for submitting issues and PR (sonic-net#947) [rsyslog]: Use timegenerated instead of timestamp (sonic-net#944) [dell]: remove nos_to_sonic_grub.cfg (sonic-net#943) [slave.mk]: Apply series of patches to SONIC_PYTHON_STDEB_DEBS targets if they exist (sonic-net#941) [rsyslog]: Use SONiC template in containers (sonic-net#940) [Broadcom]: Remove BRCM_OPENNSL library and upgrade BRCM_SAI to 3.0.3.2 (sonic-net#938) [baseimage]: allocate varlog disk in the initramfs stage (sonic-net#936) [sairedis]: revert deadlock fix in sonic-sairedis submodule (sonic-net#934) Replace CRLF line endings with LF (sonic-net#932) Fix confusing comment (sonic-net#931) Update sfputil support for Ingrasys S9100 (sonic-net#929) [quagga]: Disable ipv4 over ipv6 and enable ipv6 over ipv4 peer group (sonic-net#922) [quagga] enable core dump for bgpd and zebra (sonic-net#927) [devices]: Update Dell s6100/z9100 platform modules (sonic-net#925) Revert "Migrate DEVICE_METADATA to db (sonic-net#919)" (sonic-net#928) Migrate DEVICE_METADATA to db (sonic-net#919) [devices]: Bump sonic-platform-modules-arista submodule (sonic-net#924) [image]: build sonic-broadcom.raw image for sonic conversion from ftos (sonic-net#901) [sonic-slave] Force pyangbind version to 0.5.10 (sonic-net#918) [Arista-7260CX3] Rename hwSKU Arista-7260CX3-64 to Arista-7260CX3-C64, introducing new hwSKU Arista-7260CX3-D108C8 (sonic-net#920) [devices]: modify sfputil plugins for mellanox devices for new platform API (sonic-net#916) [cavm]Update sai revision and packet driver (sonic-net#914) [translate-acl] Specify pyangbind version to not introduce new dependency (sonic-net#915) Update sfputil support for Arista platforms (sonic-net#912) Port speed (sonic-net#879) [Accton]: Add a new supported device AS5712-54X (sonic-net#898) [kernel]: update kernel submodule (sonic-net#910) [device]: Updated dell s6100 submodule to 5ab014 (sonic-net#909) [broadcom]: update broadcom sai package to 2.1.5.1-17 (sonic-net#908) IPv4 prefixes shouldn't be sent by default over IPv6 session with FRR. (sonic-net#905) [submodule]: update sonic linux kernel (sonic-net#906) [sonic-sairedis] update sairedis submodule (sonic-net#211, sonic-net#212) (sonic-net#904) [mlnx-fw-upgrade]: Define required FW version in build time. (sonic-net#902) [SAI]: Remove the SAI submodule from buildimage repo (sonic-net#893) [Submodule update]: sonic-utilities (sonic-net#888) Revert "[mellanox]: Update Mellanox SAI version" [mellanox]: Update Mellanox SAI version [utilities]: Update sonic-utilities submodule [swss-common]: Update sonic-swss-common submodule [mellanox]: Disable fsat boot mode for SX kernel [quagga]: Update sonic-quagga submodule [Broadcom]: Update Broadcom SAI/SDK version (sonic-net#883) Squash merge v1.0.3 branch onto master

Add 'hw-management-generate-dump.sh' to 'show techsupport' command (#923) Add common PCIe diag tool (#771) Multi-asic changes for config bgp commands and utilities. (#910) Loopback interface configuration CLIs (#879) Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>

* 7812372 2018-11-08 | Update changelog to v1.3.5 (HEAD, origin/v1.3) [Guohan Lu] * a98bbfe 2018-11-08 | build saiserver and saiserver-dbg packages [Guohan Lu] * 2d3cce2 2018-11-02 | Change SAI_MIRROR_SESSION_ATTR_VLAN_HEADER_VALID to CREATE_AND_SET (sonic-net#879) [Shuotian Cheng] Signed-off-by: Guohan Lu <gulv@microsoft.com>

* Adding configuration CLIs for loopback interfaces

…omatically (#19121) #### Why I did it src/sonic-swss-common ``` * 391e27b - (HEAD -> master, origin/master, origin/HEAD) Add new table schema for BMP feature. (#879) (4 days ago) [Feng-msft] * 138b32e - [swig]: Fix swig template memory leak on issue 17025 (#876) (6 days ago) [Ze Gan] ``` #### How I did it #### How to verify it #### Description for the changelog

…omatically (sonic-net#19121) #### Why I did it src/sonic-swss-common ``` * 391e27b - (HEAD -> master, origin/master, origin/HEAD) Add new table schema for BMP feature. (sonic-net#879) (4 days ago) [Feng-msft] * 138b32e - [swig]: Fix swig template memory leak on issue 17025 (sonic-net#876) (6 days ago) [Ze Gan] ``` #### How I did it #### How to verify it #### Description for the changelog

andriymoroz-mlnx added 4 commits July 5, 2017 15:00

Add port speed configuration

8bd272c

Add DeviceInfos support in minigraph parser

965b5fb

Merge branch 'master' into port_speed

0eb6913

Conflicts: platform/mellanox/mlnx-sai.mk

Add cfggen test 'test_minigraph_ethernet_interfaces'

e12daee

msftclas added the cla-already-signed label Aug 10, 2017

stcheng added the Enhancement ➕ label Aug 15, 2017

lguohan reviewed Aug 18, 2017

View reviewed changes

lguohan requested changes Aug 18, 2017

View reviewed changes

Fixed PR comments

dcb58a4

andriymoroz-mlnx added 2 commits August 22, 2017 19:03

Merge remote-tracking branch 'upstream/master' into port_speed

7545d41

Update sonic-swss submodule reference

d49c045

andriymoroz-mlnx force-pushed the port_speed branch from 59e17cc to d49c045 Compare August 22, 2017 16:08

lguohan approved these changes Aug 23, 2017

View reviewed changes

lguohan merged commit 48b0beb into sonic-net:master Aug 24, 2017

stcheng mentioned this pull request May 9, 2019

[swss]: Update sonic-swss submodule #2879

Merged

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

Return 0 for CRM counter instead of None if no match (sonic-net#879)

ff9b93b

shlomibitton mentioned this pull request May 26, 2020

[submodule update] sonic-utilities #4648

Merged

stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021

Loopback interface configuration CLIs (sonic-net#879)

10c7ba1

* Adding configuration CLIs for loopback interfaces

AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this pull request Apr 14, 2022

[meta] Fix vlan set test (sonic-net#879)

6a5f379

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port speed #879

Port speed #879

andriymoroz-mlnx commented Aug 10, 2017

lguohan commented Aug 18, 2017

lguohan Aug 18, 2017 •

edited

Loading

lguohan Aug 18, 2017 •

edited

Loading

lguohan Aug 18, 2017

lguohan Aug 18, 2017

lguohan Aug 18, 2017

lguohan left a comment

lguohan commented Aug 22, 2017

lguohan commented Aug 23, 2017 •

edited

Loading

Port speed #879

Port speed #879

Conversation

andriymoroz-mlnx commented Aug 10, 2017

lguohan commented Aug 18, 2017

lguohan Aug 18, 2017 • edited Loading

Choose a reason for hiding this comment

lguohan Aug 18, 2017 • edited Loading

Choose a reason for hiding this comment

lguohan Aug 18, 2017

Choose a reason for hiding this comment

lguohan Aug 18, 2017

Choose a reason for hiding this comment

lguohan Aug 18, 2017

Choose a reason for hiding this comment

lguohan left a comment

Choose a reason for hiding this comment

lguohan commented Aug 22, 2017

lguohan commented Aug 23, 2017 • edited Loading

lguohan Aug 18, 2017 •

edited

Loading

lguohan Aug 18, 2017 •

edited

Loading

lguohan commented Aug 23, 2017 •

edited

Loading