-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iccpd] Fix iccpd env #8945
[iccpd] Fix iccpd env #8945
Conversation
@gitsabari note, previously code branch with port isolation group was dead and port isolation group was not used. |
@lguohan could you please review it? |
@qiluo-msft could you please review it? |
@lguohan could you please review it? |
@qiluo-msft could you please review it? |
@gechiang could you please review it? |
@gitsabari, @Praveen-Brcm , please take a look |
@lguohan could you please help to review it? |
Looks good to me. But let's wait for @gitsabari, @Praveen-Brcm to review and approve. |
Changes looks good to me. Please add me to the reviwers list to approve. Thanks. |
@Praveen-Brcm |
changes looks good to me also. Please add me to reviewer list to approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @Praveen-Brcm has also reviewed and approved.
Why I did it
mclagsyncd
source is in sonic-swss repo, its binary is insideiccpd
container and binary useplatform
env var https://github.com/Azure/sonic-swss/blob/ef6b5d48297f7f19a8ec57e2d7b997fd0919bb9d/mclagsyncd/mclaglink.cpp#L191But
platform
env is set only insideswss
container services, for example https://github.com/Azure/sonic-buildimage/blob/7d40384c58848c368ecf7b2c520f7a17fcbc8bdb/dockers/docker-orchagent/orchagent.sh#L7So code doesn't support branch with port isolation group, because env is not set.
How I did it
Added env to iccpds start script, like in
orchagent
How to verify it
Delete all isolation group destination ports
, hence code branch with port isolation group was used instead of ACLWhich release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)