DellEMC: S6000,S6100 SFP refactor #9016
Conversation
|
@aravindmani-1 could you resolve merge conflict? |
Done. |
|
@aravindmani-1 build is failing even after repeated submission. please check. |
|
/azpw run |
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
The failures are not related to my changes. can you please check?. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azpw run |
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
@aravindmani-1 can you rebase to latest master and do force push to trigger the checks again? |
aravindmani-1
force-pushed
the
DellEMC_SFP_Refactor
branch
from
bb79499
to
fc52cdb
Compare
|
@prgeor can we add the label to include this on 202012? |
|
@sachinv-msft SFP-refactor is NOT supported in 202012 |
|
@prgeor why is it not supported on 202012? |
its risky change |
|
@prgeor i would like some clarification on next steps on how would we eventually support this moving forward? |
please ping me over teams, so that we can discuss. |
|
@prgeor @qiluo-msft Could you please help to cherry pick this PR to 202111 branch?. |
prgeor
added
the
Request for 202111 Branch
* DellEMC: S6000,S6100 SFP refactor
Why I did it
Since SFP refactor has common API's, redundant platform API has to be removed.
How I did it
Removed redundant SFP API in Dell S6000, S6100 platforms
How to verify it
UT:
dell_sfp_refactor.txt
Note:
Please merge this PR only when sonic-platform-common submodule is updated with sonic_xcvr package in sonic-buildimage repo.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Removed redundant platform SFP APIs.
A picture of a cute animal (not mandatory but encouraged)