V1.0.3 backup VLAN trunk implementation #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JipanYanga, |
|
@taoyl-ms to review |
|
Hi Jipan, is it possible that you could split this pull request into multiple related pull requests, e.g. one for the orchagent change, one for the config agent, etc. |
|
Hi Shuotian,
Technically I could split the changes into two parts, one for orchagent and the other for config agent. The hostenv setup in congfigAgent and ASIC setup from Orchagent need to work together to get VLAN trunk functioning.
What is the purpose of this splitting? If it is for simplifying the review, I could do it. The commit history log for VLAN trunk will be lost.
Thanks,
Jipan
From: Shuotian Cheng <notifications@github.com>
Reply-To: Azure/sonic-buildimage <reply@reply.github.com>
Date: Thursday, August 24, 2017 at 2:09 PM
To: Azure/sonic-buildimage <sonic-buildimage@noreply.github.com>
Cc: Jipan Yang <jipan.yang@alibaba-inc.com>, Mention <mention@noreply.github.com>
Subject: Re: [Azure/sonic-buildimage] V1.0.3 backup VLAN trunk implementation (#911)
Hi Jipan, is it possible that you could split this pull request into multiple related pull requests, e.g. one for the orchagent change, one for the config agent, etc.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Azure/sonic-buildimage","title":"Azure/sonic-buildimage","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/Azure/sonic-buildimage"}},"updates":{"snippets":[{"icon":"PERSON","message":"@stcheng in #911: Hi Jipan, is it possible that you could split this pull request into multiple related pull requests, e.g. one for the orchagent change, one for the config agent, etc."}],"action":{"name":"View Pull Request","url":"#911 (comment)"}}}
|
|
I think this is a large feature. here you squash them into one commit. It is already losing the commit history. Either splitting the pull request, or have a better commit history so we do a regular merge commit instead of a squash one. This will benefit both git commit view and pull request review. |
|
Hello, @JipanYanga , sorry for the confusion. I'm referring to the sonic-swss code changes. |
stcheng
reviewed
Aug 25, 2017
| @@ -4,6 +4,7 @@ SHELL = /bin/bash | |||
|
|
|||
| MAIN_TARGET = libnl-3-200_$(LIBNL3_VERSION)_amd64.deb | |||
| DERIVED_TARGETS = libnl-3-dev_$(LIBNL3_VERSION)_amd64.deb \ | |||
| libnl-3-200-dbg_$(LIBNL3_VERSION)_amd64.deb \ | |||
There was a problem hiding this comment.
Have been seeing issues related to netlink, this to get the dbg file copied to target/debs folder. It makes it easier to find the libnl debug package and install it when needed.
|
target branch not active. |
seiferteric
pushed a commit
to project-arlo/sonic-buildimage
that referenced
this pull request
Oct 14, 2019
* Update src/sonic-swss from branch 'broadcom_sonic'
to cd2a2e0504412254d4d44f5f97946921dc246cc6
- Merge 201904 branch to broadcom_sonic branch on Mon Jul 1 13:57:57 PDT 2019
Change-Id: I77bef1ba390171f204e27387bee0226ddab38971
- [debian]: Do not build test when building with real SAI (sonic-net#932)
- swss-orchagent: add new orch for vnet routes/tunnel routes tables in CONFIG_DB (sonic-net#907)
* Vnet route persistence
Signed-off-by: weixi.chen@microsoft.com
- pkill -9 zebra for frr warm restart VS test fix (sonic-net#927)
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
- [vnetorch]: Fix tunnel route removal flow for bitmap VNET (sonic-net#912)
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
- [orchagent]: Added support of PFC WD for BFN platform (sonic-net#823)
* [orchagent]: Added support of PFC WD for BFN platform
Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>
* Fixed review comments
Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>
* Use PFC WD ACL handler for BFN platform
- [aclorch] unittest by gtest (sonic-net#924)
- [orchagent]: Remove try/catch for correct coredump file (sonic-net#790)
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
- Set LAG mtu value based on kernel netlink msg (sonic-net#922)
* Update mtu value based on kernel netlink msg
* Push the calculated MTU size into the fvVector
- Address review comment: remove data member m_entriesCreated, which is introduced for dependancy resolution purpose. (sonic-net#839)
Signed-off-by: Wenda Ni <wenni@microsoft.com>
- [vxlanorch] Ambiguous return code for removeNextHopTunnel (sonic-net#880)
Change to return false when isTunnelExists is fail
- [vnet]: Extend Bitmap VNET test with "remove" flows (sonic-net#900)
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
- add dynamic transceiver tuning support (sonic-net#821)
- Remove *_LEFT fields to allow PFC watchdog to enter fresh into the (sonic-net#897)
operational/storm state
Signed-off-by: Wenda Ni <wenni@microsoft.com>
- Fix vlan incremental config and add vs test cases (sonic-net#799)
* Fix vlan incremental config and add vs test cases
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
- Suppress storm detect counter increment for ongoing pfc storm case during a warm reboot (sonic-net#869)
* Suppress storm detect counter increment for ongoing pfc storm case during
a warm reboot
Signed-off-by: Wenda Ni <wenni@microsoft.com>
* Comment touch-up
Signed-off-by: Wenda Ni <wenni@microsoft.com>
- [warm restart assist] assume vector values could be reordered (sonic-net#921)
When comparing 2 vectors, assume their elements could be re-ordered.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
- [test]: Mark some VLAN tests as Stretch only (sonic-net#903)
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
- [aclorch]: Add MIRROR_DSCP table type (sonic-net#906)
Add MIRROR_DSCP table to support creating an ACL mirro table
that only matches DSCP value/mask.
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
- [debian] increment debian compatibility to 10 to enable parallel package build (sonic-net#911)
From debhelper man pages:
"If neither option is specified, debhelper currently defaults to
--parallel in compat 10 (or later) and --no-parallel otherwise."
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
- [test]: Skip tests under investigation (sonic-net#919)
- [vstest]: Update the mirror session state table name (sonic-net#917)
Due to the change
c033b23
Fix MIRROR_SESSION table macro name (sonic-net#802)
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
- Ignore neighbor entry with BCAST MAC, check SAI status exists (sonic-net#914)
* Ignore neighbor entry with BCAST MAC, check SAI status exists
* Addressed review comment
- Fix MIRROR_SESSION table macro name (sonic-net#802)
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
- [policerorch]: Add PolicerOrch to bundle with mirror session (sonic-net#889)
Now that we could create a policer for the mirror session to
throttle the mirroring traffic.
configuration:
POLICER|NAME:
meter_type:packets|bytes
mode:sr_tcm|tr_tcm|storm_control
cir|DIGITS
cbs|DIGITS
pir|DIGITS
pbs|DIGITS
corlor_source:aware|blind
red_action:drop
yellow_action:drop
green_action:drop
MIRROR_SESSION|NAME:
policer:policer_name
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
…age build (sonic-net#911) From debhelper man pages: "If neither option is specified, debhelper currently defaults to --parallel in compat 10 (or later) and --no-parallel otherwise." Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
abdosi
added a commit
to abdosi/sonic-buildimage
that referenced
this pull request
May 14, 2020
Fix is_mgmt_vrf_enabled when MGMT_VRF_CONFIG is not present the config (sonic-net#885) Changes to support acl-loader command for multi-npu platforms. (sonic-net#908) Stop/Start restapi server upon config reload (sonic-net#911) [fanshow] Add column drawer name and led status to output of show platform(sonic-net#991) [MultiDB] use sonic-db-cli instead of redis-cli in new added codes (sonic-net#907) [show] Add `ntpstat` output to `show ntp` (sonic-net#861) [config] Log invocation of config commands to syslog (sonic-net#259) Remove dependency on click-default-group package (sonic-net#903) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'rese…' (sonic-net#904) [show] Add 'errors' and 'rates' subcommands to 'show interfaces count…(sonic-net#900) [config] Support load_minigraph command for multi NPU platform (sonic-net#896) [Vnet] Fix NameError for 'swsssdk' and align output (sonic-net#902)
abdosi
added a commit
that referenced
this pull request
May 18, 2020
Fix is_mgmt_vrf_enabled when MGMT_VRF_CONFIG is not present the config (#885) Changes to support acl-loader command for multi-npu platforms. (#908) Stop/Start restapi server upon config reload (#911) [fanshow] Add column drawer name and led status to output of show platform(#991) [MultiDB] use sonic-db-cli instead of redis-cli in new added codes (#907) [show] Add `ntpstat` output to `show ntp` (#861) [config] Log invocation of config commands to syslog (#259) Remove dependency on click-default-group package (#903) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'rese…' (#904) [show] Add 'errors' and 'rates' subcommands to 'show interfaces count…(#900) [config] Support load_minigraph command for multi NPU platform (#896) [Vnet] Fix NameError for 'swsssdk' and align output (#902)
abdosi
added a commit
that referenced
this pull request
May 20, 2020
[201911][show] Fix abbreviations for 'show ip bgp ...' commands (#909) Changes to support acl-loader and mirror-session config commands for multi-npu platforms. (#908) Changes to commands config reload/load-minigraph (#919) Stop/Start restapi server upon config reload (#911) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (#904)
bbinxie
added a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
May 22, 2020
* [201911][devices] skip_fancontrol for wedge 100 barefoot platforms (sonic-net#4528) * [device] DellEMC s5232f 50G hwsku support (sonic-net#4525) * [device] DellEmc S5232 support for new hwsku C8D48 8 100G ports and 48 50G ports * 10G ports update for S5232 hwsku-C8D48 Signed-off-by: Srideep Devireddy <srideep_devireddy@dell.com> * DellEMC S6000 updated sensors.conf (sonic-net#4568) Change PSU MAX temperature to 80 degree Change tmp75 sensors default temperature value from 25/50 to 70/80 degree. * [sonic-slave-stretch]: install same version for docker-ce and docker-ce-cli difference versions can cause compatibility issue between the server and client Signed-off-by: Guohan Lu <lguohan@gmail.com> * [baseimage]: install same version for docker-ce and docker-ce-cli Signed-off-by: Guohan Lu <lguohan@gmail.com> * [FRR]: Update frr to latest 7.2.1-s3 (sonic-net#4294) - Updated to latest frr 7.2.1 from the master. - Updated patches accordingly * [sonic-buildimage] updated minigraph for ACL Table data and ACL Interface Binding for Multi-NPU platforms (sonic-net#4491) * [sonic-buildimage] updated minigraph for ACL Table data and ACL Interface binding update for multu-npu platform based on subrole as "Frontend" or "Backend". For backend npu no ACL table is associated. For frontend npu only front-panel interface are associated. Updated with test case and fix typo in sample-mingraph for npu Address Review comments Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Fixed the logic as per preview comment. Interface Filter logic only applies to Everflow/Mirror tables. * Address Review Comments. * Changes for LLDP docker to support multi-npu platforms (sonic-net#4530) * Changes for LLDP for Multi NPU Platoforms:- a) Enable LLDP for Host namespace for Management Port b) Make sure Management IP is avaliable in per asic namespace needed for LLDP Chassis configuration c) Make sure chassis mac-address is correct in per asic namespace d) Do not run lldp on eth0 of per asic namespace and avoid chassis configuration for same e) Use Linux hostname instead from Device Metadata for lldp chassis configuration since in multi-npu platforms device metadata hostname will be differnt Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Address Review Comment with following changes: a) Use Device Metadata hostname even in per namespace conatiner. updated minigraph parsing for same to have hostname as system hostname and add new key for asic name b) Minigraph changes to have MGMT_INTERFACE Key in per asic/namespace config also as needed for LLDP for setting chassis management IP. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Address Review Comments * Moved utility functions for multi-npu platforms from sonic-utilities to sonic_device_util.py (sonic-net#4559) * Moved utility functions for multi-npu platforms from sonic-utilities config/main.py to here so that they can be used any module * Fix the issue with test run during compilation with acl-uploader PR#908 of sonic-utilities. * Fix get_num_npu as it was retuning string and not int * Address Review Comments * Address Review Comments * Fix for issue where image is compile with flag ENABLE_DHCP_GRAPH_SERVICE (sonic-net#4573) and then we load image and reboot even if there was existing config_db.json we will look for DHCP Service. we should disbale update_graph in such cases. This behaviour is silimar to what we have in 201811 image. * Change to enable redistribute connected on Frontend asics instead of backend asics (sonic-net#4588) Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> * [DellEMC] S6000 Disable Low power mode by default (sonic-net#4592) * [BFN] Updated Barefoot SDK to 2020-05-07 (sonic-net#4566) Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com> * [minigraph] Add tags for egress mirror tables (sonic-net#4526) Signed-off-by: Danny Allen <daall@microsoft.com> * [Submodule update] sonic-utlities with PR's [201911][show] Fix abbreviations for 'show ip bgp ...' commands (sonic-net#909) Changes to support acl-loader and mirror-session config commands for multi-npu platforms. (sonic-net#908) Changes to commands config reload/load-minigraph (sonic-net#919) Stop/Start restapi server upon config reload (sonic-net#911) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904) * [minigraph] Support FECDisabled in minigraph parser (sonic-net#4556) (sonic-net#4624) Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com> * [ntp] enable/disable NTP long jump according to reboot type (sonic-net#4577) * [ntp] enable/disable NTP long jump according to reboot type - Enable NTP long jump after cold reboot. - Disable NTP long jump after warrm/fast reboot. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * fix typo * further refactoring * use sonic-db-cli instead * [arista]: remove the soc property disabling sram scan (sonic-net#4623) * Changes to support config-setup service for multi-npu (sonic-net#4609) * Changes to support config-setup service for multi-npu platforms. For Multi-npu we are not supporting as of now config initializtion and ZTP. It will support creating config db from minigraph or using config db from previous file system Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Address Review Comments. * Address Review comments * Address Review Comments of using pyhton based config load_minigraph/ config save/config reload from shell scripts so that we don't duplicate code. Also while running from shell we will skip stop/start services done by those commands. * Updated to use python command so no code duplication. * [config]: Fix the device type and internal bgp session status for multi NPU platforms (sonic-net#4600) * The following changes for multi-npu platforms are done - Set the type in device_metadata for asic configuration to be same as host - Set the admin-status of internal bgp sessions as up Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> * Adding new BGP peer groups PEER_V4_INT and PEER_V6_INT. (sonic-net#4620) * Adding new BGP peer groups PEER_V4_INT and PEER_V6_INT. The internal BGP sessions will be added to this peer group while the external BGP sessions will be added to the exising PEER_V4 and PEER_V6 peer group. * Check for "ASIC" keyword in the hostname to identify the internal neighbors. * [submodule update] sonic-swss with PR [vnet] Fix IP2ME route creation logic for BITMAP VNET interface (sonic-net#1284) * [submodule update] sonic-util Revert "[config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904)" Multi-asic changes for config bgp commands and utilities. (sonic-net#910) * [submodule update] sonic-rest API's PR#39 Setup module versioning Add support for get all Vlans (#37) * Update golang version for 1.11.5 to 1.14.2 (sonic-net#4520) Co-authored-by: Myron Sosyak <49795530+msosyak@users.noreply.github.com> Co-authored-by: Srideep <srideep_devireddy@dell.com> Co-authored-by: paavaanan <paavaanan_t_n@dell.com> Co-authored-by: Guohan Lu <lguohan@gmail.com> Co-authored-by: pavel-shirshov <pavelsh@microsoft.com> Co-authored-by: abdosi <58047199+abdosi@users.noreply.github.com> Co-authored-by: arlakshm <55814491+arlakshm@users.noreply.github.com> Co-authored-by: Santhosh Kumar T <53558409+santhosh-kt@users.noreply.github.com> Co-authored-by: Andriy Kokhan <43479230+akokhan@users.noreply.github.com> Co-authored-by: Danny Allen <daall@microsoft.com> Co-authored-by: Abhishek Dosi <abdosi@microsoft.com> Co-authored-by: Qi Luo <qiluo-msft@users.noreply.github.com> Co-authored-by: Ying Xie <yxieca@users.noreply.github.com> Co-authored-by: Samuel Angebault <staphylo@arista.com> Co-authored-by: judyjoseph <53951155+judyjoseph@users.noreply.github.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
shi-su
added a commit
that referenced
this pull request
Aug 28, 2021
Update the sonic-sairedis submodule. The following is a list of new commits in the submodule. f85322e Advance SAI submodule (#911) 66c1a3d [syncd] Check warm vids right after discover (#907) 1020de7 Change the log severity leve from ERROR to NOTICE if getStatus is not supported by vendor (#908) 5349a9d Add support for BFD notification (#903) 6ff9100 [MACsec]: Fix Bug: MACsec device will be terminated exceptionally if the MACsec port was disabled in runtime (#875) b91f75f [sairedis] Add warning on double switch id allocation 518b93a [tests] Adapt tests to armhf arch 36106e9 [vslib] Unify bulkCreate for entries with perf timer 88cf0f7 [vslib] Remove dead code f282690 Simplify declare every entry macro reuse b28e5e3 [tests] Add missing memory header 980bba4 Add missing pyext in makefile 00ffa62 Update aspell 4a5d3b5 Add SwitchBCM81724 tests 8a7b712 Remove dead code from SwitchBCM81724 71834d2 Fix supported object list size bug on SwitchBCM81724 0da464b Add SwitchBCM56850 tests 4d7956b Add SwitchMLNX2700 tests 2e418ab [saivs] Refactor headers a4b15a6 Correct entry in SaiUnittests b5a2f63 Update aspell 923ab2f Add SwitchContainer tests 484beb1 Add Switch tests cc2e078 Add SwitchConfig tests 724ce74 Add TrafficFilterPipes tests 03e4923 Add HostInterfaceInfo tests 5db4e72 Add TrafficForwarder tests 1b4d6d1 Add SwitchConfigContainer tests 7a32cd6 Add Signal tests 7c016f0 Add SelectableFd tests 21e735d Update SaiUnittests tests 353a058 Add SaiUnittests tests 5572102 Fix ContextConfigContainer tests 0fd06c9 Move error to throw on sai unittests 3c3b369 Add db channel from context config to VS 330c561 Fix ResourceLimiterContainer 30f5825 Add missing files for ResourceLimiter tests 8a871ee Update aspell 467e228 Add ResourceLimiterParser tests f6b35da Add ResourceLimiterContainer tests 99f04e9 Remove default ctr/dtr from struct MACsecManager 9381f2d Add ResourceLimiter tests ab2ef9d Add RealObjectIdManager tests 5f6b004 Add NetMsgRegistrar tests 8142375 Add MACsecIngressFilter tests 888197d Add MACsecEgressFilter tests 8ed6e36 Add MACsecAttr tests b14b598 Add LaneMapFileParser tests 38a52ac Add LaneMapContainer tests 2997892 Add LaneMap tests 734c7ef Add SaiAttrWrap tests c6e7ac0 Add FdbInfo tests 7ed640d Add EventQueue tests 752d424 Add EventPayloadPacket tests 85042f4 Add EventPayloadNetLinkMsg tests 8bf97ed Add CorePortIndexMapFileParser tests ff7c6c5 Add CorePortIndexMapContainer tests 4598078 Add CorePortIndexMap tests d6f7435 Add vslib ContextConfigContainer tests bc27a04 Add sairedis api tests 9a96cd7 Fix tam tests a3bc56e Move tam api to separate test 9d1032b Add sairedis tam api tests f1570e5 Add sairedis lib tests 91ce42c Check for null pointer on bulk entries apis 78252c7 Update interface query tests cf956b6 Fix error code on dbg dump e7e1d80 Fix api query when unspecified api passed cd93183 Tests rename fix qosmaps to qosmap 5e9e0c9 Rename fix qosmaps to qosmap 5b67e6b Add virtual router tests 0d946cf Fix lag tests 27bbde7 Add udf tests 31a3613 Add tunnel tests 3366e47 Update tam tests 5b06fb3 Add tam tests 02d6d89 Add system port tests 9224e13 Add switch tests c2c0af8 Add stp tests 2192040 Add segment route tests 702dff6 Add scheduler group tests 24e3d92 Add sample packet tests fda4f80 Add rpf group tests 5ecab66 Add router interface tests 9114865 Add route tests 895129e Add queue tests e01707f Add qos map tests 8162205 Add port tests 46d15e9 Add policer tests 36cf6d1 Add next hop group tests 2200e38 Add next hop tests 1b2bf3c Fix lag tests 27a2b90 Add neighbor tests fc28438 Add nat tests 7468777 Add mpls tests 82ca7e5 Add mirror tests adbcfd9 Add mcast fdb tests d624231 Add macsec tests 72cfe42 Add lag tests 9f1b54b Add l2mc group tests d16bc95 Add l2mc tests 3d07e59 Fix isolation tests 85e5ac0 Add isolation group tests 1c4c11f Add ipcm group tests b6ed3e0 Add ipcm tests 78e8b68 Add fdb tests 8af035b Add dtel tests b56c601 Add counter tests 7c61b13 Add buffer tests fe6a041 Add bridge tests ec96469 Add bmtor tests f6d5d7d Add bfd tests d3419e0 Add acl tests 14a26b1 Add hash and hostif tests 18a09f9 Move hostintf to hostif name in lib and libvs a02b593 Add vs vlan tests 3122b37 Update wred tests 312627f Remove comments from test makefile 466a589 Update unittests 2418585 Preapre unittests skeleton 31718cf [unittest] Add unittest skeleton a4e2d28 [syncd] Fix defines in Makefile.am a4bc9e4 Remove unnecessary include from Makefiles b2e368e Update debian/libsaimetadata-dev.install 222a5b0 Update .gitignore f77ed71 Bring back pyext module 6942de0 Propagate inc and src merge 378bfff Merge include and src for lib and vslib 89c004a Whitespace refactor 3b02209 Simplify SaiInterface macros b7ec50a Add find cross include tool ce6ad22 Remove unnecessary include from SaiInterface.h 8172de2 Remove unnecessary comments for include 50bfd42 Move common SAI includes to configure.ac f40a168 Refactor Makefile.am files even more c91b117 [pyext] Update Makefile.am with top_srcdir 0a0ff45 [sairedis] Update Makefile.am 7b1a0b9 Rename saiserialize.cpp to SaiSerialize.cpp 47dac40 [vslib] Move sai_vs.cpp to sai_vs_interfacequery.cpp 39d003c Add check for configure conflict code-coverage/enable-debug add29e0 Move DBGFLAGS initialization to configure.ac e75abb7 Refactor all Makefile.am 9bb541a Remove white spaces from line endings 2e0b74b Add TODO for future split single file binaries 5b71d21 Propagate Notifications changes aaa519f Move Notificatios to libsaimeta 855be73 Move SelectableChannel classes to libsaimeta 016b5d9 [tests] [sairedis] Update include to use direct name 0fffcb0 Propagate PerformanceIntervalTimer changes 9d17b0a Move PerformanceIntervalTimer to libsaimeta cc5ab4c Move joinFieldValues to libsaimeta 638ca82 Move getHardwareInfo to libsaimeta 3951504 [vslib] Fix VirtualObjectIdManager multi arch logging 5b888a3 Remove unused SAIFLAGS from makefiles c9f05ea Remove ../ from includes 737393d Move SaiInterface to meta directory e13991a [debian] Update install to include only sai*.h files 8e3a8fb [meta] Make swap lib naming for better read in Makefile.am f1b632c Update autoclean.sh 6f319f8 Update .gitignore
AidanCopeland
pushed a commit
to Metaswitch/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
![https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open](https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.