[bgpcfgd] Add bgpcfgd support to advertise routes #9197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Nov 16, 2021
src/sonic-bgpcfgd/bgpcfgd/main.py
Outdated
| @@ -59,6 +60,8 @@ def do_work(): | |||
| BBRMgr(common_objs, "CONFIG_DB", "BGP_BBR"), | |||
| # Static Route Managers | |||
| StaticRouteMgr(common_objs, "CONFIG_DB", "STATIC_ROUTE"), | |||
| # Route Advertisement Managers | |||
| AdvertiseRouteMgr(common_objs, "STATE_DB", "ADVERTISE_NETWORK"), | |||
There was a problem hiding this comment.
Is this defined in the schema? if not, could you please raise a PR?
There was a problem hiding this comment.
Defined the table in the schema. Pending on swss-common submodule upgrade #9275. PR test would fail before that one merges.
| OP_ADD = 'ADD' | ||
|
|
||
|
|
||
| def set_handler(self, key, data): |
There was a problem hiding this comment.
does the set handler invoked when bgp is restarted? please confirm
There was a problem hiding this comment.
I checked the configuration after bgp restart and it would be invoked after bgp restart.
| self.cfg_mgr.push_list(cmd_list) | ||
|
|
||
|
|
||
| def on_bgp_asn_change(self): |
There was a problem hiding this comment.
We may also want to add the new table to cleanup script to avoid stale entries in swss restarts
There was a problem hiding this comment.
Added the table in the script you suggested to clean up in swss restart.
prsunny
previously approved these changes
Nov 19, 2021
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
previously approved these changes
Nov 23, 2021
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Nov 29, 2021
shi-su
added a commit
to shi-su/sonic-buildimage
that referenced
this pull request
Jan 6, 2022
Why I did it Add bgpcfgd support to advertise routes. How I did it Make bgpcfgd subscribe to the ADVERTISE_NETWORK table in STATE_DB and configure route advertisement accordingly. How to verify it Added unit tests in bgpcfgd and verify on KVM about route advertisement.
5 tasks
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jan 10, 2022
Why I did it Add bgpcfgd support to advertise routes. How I did it Make bgpcfgd subscribe to the ADVERTISE_NETWORK table in STATE_DB and configure route advertisement accordingly. How to verify it Added unit tests in bgpcfgd and verify on KVM about route advertisement.
shi-su
added a commit
that referenced
this pull request
Jan 26, 2022
Why I did it Cherry pick changes in #9197 to 202012 branch Add bgpcfgd support to advertise routes. How I did it Make bgpcfgd subscribe to the ADVERTISE_NETWORK table in STATE_DB and configure route advertisement accordingly. How to verify it Added unit tests in bgpcfgd and verify on KVM about route advertisement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add bgpcfgd support to advertise routes.
How I did it
Make bgpcfgd subscribe to the ADVERTISE_NETWORK table in STATE_DB and configure route advertisement accordingly.
How to verify it
Added unit tests in bgpcfgd and verify on KVM about route advertisement.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)