Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build]: Enable arm pr check #9362

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Conversation

xumia
Copy link
Collaborator

@xumia xumia commented Nov 24, 2021

Why I did it

Support marvell-armhf dpkg cache and the azp check.
Waiting for merging PR #9381 to 202012 branch, so only azp template change in this PR.

Move the VS build to a new stage BuildVS, change the Test stage only depending on BuildVS, running the BuildVS and the other platform's build in parallel. The Test stage do not has dependency on the marvel-armhf build, reduce the overall build time caused by longer build time of marvel-armhf build.

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@xumia xumia added the Build label Nov 24, 2021
@xumia xumia changed the title Enable arm pr check [Build]: Enable arm pr check Nov 24, 2021
@xumia xumia force-pushed the enable-arm-pr-check branch from 208fd0a to 069f752 Compare November 30, 2021 13:17
@xumia xumia marked this pull request as ready for review November 30, 2021 13:23
@xumia
Copy link
Collaborator Author

xumia commented Nov 30, 2021

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@xumia
Copy link
Collaborator Author

xumia commented Nov 30, 2021

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).


- stage: Build
pool: sonicbld
dependsOn: []
Copy link
Collaborator

@qiluo-msft qiluo-msft Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fixing something? do we need it? #Closed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiluo-msft , it is to declare the build stage does not depend on any other stage.
A new stage BuildVS is added, the Test stage only depends on the BuildVS stage.
The Build stage, including broadcom, mellanox, marvell-armhf, can be run in parallel with BuildVS stage.
The Build stage will take more time than before, since marvel-armhf will take longer time to build.

@@ -43,10 +43,29 @@ stages:
buildOptions: 'USERNAME=admin SONIC_BUILD_JOBS=$(nproc) ${{ variables.VERSION_CONTROL_OPTIONS }}'
jobGroups:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see these lines repeated in below stage. Can we reuse?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can check if we can reuse it, it depends on if the variables can be used another variable in compiling time.

Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With minor comment on reuse, others lgtm.

@xumia
Copy link
Collaborator Author

xumia commented Dec 1, 2021

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@xumia
Copy link
Collaborator Author

xumia commented Dec 2, 2021

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lguohan
Copy link
Collaborator

lguohan commented Dec 3, 2021

do you know why marvell_armhf build still take 5 hours for the pr build?

@xumia
Copy link
Collaborator Author

xumia commented Dec 3, 2021

do you know why marvell_armhf build still take 5 hours for the pr build?

No dpkg cache now, We need to merge the PR, and do a official build, then we have dpkg cache.

@xumia
Copy link
Collaborator Author

xumia commented Dec 3, 2021

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@xumia
Copy link
Collaborator Author

xumia commented Dec 3, 2021

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xumia xumia merged commit 0535173 into sonic-net:202012 Dec 4, 2021
@xumia xumia deleted the enable-arm-pr-check branch December 4, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants