[Mellanox] Rename platform x86_64-mlnx_msn4800 to x86_64-nvidia_sn4800 #9512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liat-grozovik
requested changes
Dec 14, 2021
There was a problem hiding this comment.
@Junchao-Mellanox please change to sn4800 and not msn4800
and you probably need to change the sonic-mgmt as well (it was just merged)
keboliu
approved these changes
Dec 14, 2021
Junchao-Mellanox
changed the title
Hi Liat, actually we are using sn4800 everywhere except the PR title... I fixed it, thanks. The sonic-mgmt PR does not need change, it also uses sn4800. |
liat-grozovik
approved these changes
Dec 15, 2021
liat-grozovik
added
the
Request for 202111 Branch
|
Please raise a new PR for 202111 branch, as this patch cannot be cleanly cherry-picked. |
judyjoseph
pushed a commit
that referenced
this pull request
Jan 9, 2022
#9512) - Why I did it Rename platform x86_64-mlnx_msn4800 to x86_64-nvidia_msn4800 - How I did it Rename platform folder as well as all code that reference the platform name - How to verify it Manual test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Rename platform x86_64-mlnx_msn4800 to x86_64-nvidia_msn4800
How I did it
Rename platform folder as well as all code that reference the platform name
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)