Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] [202012] Optimize thermal policies #9665

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

Junchao-Mellanox
Copy link
Collaborator

Why I did it

Optimize thermal control policies to simplify the logic and add more protection code in policies to make sure it works even if kernel algorithm does not work.

How I did it

  1. Reduce unused thermal policies
  2. Add timely ASIC temperature check in thermal policy to make sure ASIC temperature and fan speed is coordinated
  3. Minimum allowed fan speed now is calculated by max of the expected fan speed among all policies
  4. Move some logic from fan.py to thermal.py to make it more readable

How to verify it

  1. Manual test
  2. Regression

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Jan 4, 2022

This pull request introduces 1 alert and fixes 1 when merging 72fc3a3 into 1eec2bc - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

@Junchao-Mellanox Junchao-Mellanox marked this pull request as draft January 5, 2022 01:49
@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review January 14, 2022 01:32
@Junchao-Mellanox
Copy link
Collaborator Author

Hi @sujinmkang , could you please kindly review and sign-off?

@liat-grozovik liat-grozovik merged commit 8e924b9 into sonic-net:202012 Jan 19, 2022
@Junchao-Mellanox Junchao-Mellanox deleted the fix-thermal-202012 branch June 12, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants