[pmon] Fix chassis_db_init exit not being expected #9858
Conversation
dgsudharsan
added
Request for 202106 Branch
Request for 202111 Branch
|
@alexrallen which platform do you see this error log message and auto restart? |
|
All platforms that I tested on show this (three separate mellanox platforms). |
|
@alexrallen Can you add " and IS_MODULAR_CHASSIS == 1" for chassis_db_init similar to chassisd instead of changing the exit code? chassisd and chassis_db_init are for modular chassis. So it shouldn |
|
@sujinmkang I am the original author of chassis_db_init. This module is intended to populate redis with metadata about the chassis such as model number, serial number, and hardware revision. This information is pulled from the Platform API chassis object. As such, this is able to run on all platforms. |
|
@alexrallen The default exit code is 0 so we don't need to set the exit code. But my question is why it crashes with "not expected". Is there anything we can improve the exit / event handling for chassis_db_init? |
|
The program is correctly exiting with code 0 according to the log. Do you know why else it would say "unexpected"? The program is not crashing it is working fine. |
- Why I did it Error log was shown on switches during boot pmon#supervisord 2021-12-22 04:27:16,709 INFO exited: chassis_db_init (exit status 0; not expected) - How I did it Add exit code zero as an expected exit code and also disable autorestart. - How to verify it Boot the switch and ensure the above log line does not appear.
- Why I did it Error log was shown on switches during boot pmon#supervisord 2021-12-22 04:27:16,709 INFO exited: chassis_db_init (exit status 0; not expected) - How I did it Add exit code zero as an expected exit code and also disable autorestart. - How to verify it Boot the switch and ensure the above log line does not appear.
…10071) Why I did it Code review was still in progress when #9858 was merged and upon further testing I have arrived at a better solution. How I did it Modified supervisord configuration j2 template for pmon to require no minimum uptime for chassisd_db_init and to remove the redundant exit_codes directive How to verify it Boot switch and verify in syslog that there are no errors related to chassis_db_init
…10071) Why I did it Code review was still in progress when #9858 was merged and upon further testing I have arrived at a better solution. How I did it Modified supervisord configuration j2 template for pmon to require no minimum uptime for chassisd_db_init and to remove the redundant exit_codes directive How to verify it Boot switch and verify in syslog that there are no errors related to chassis_db_init
…10071) Why I did it Code review was still in progress when #9858 was merged and upon further testing I have arrived at a better solution. How I did it Modified supervisord configuration j2 template for pmon to require no minimum uptime for chassisd_db_init and to remove the redundant exit_codes directive How to verify it Boot switch and verify in syslog that there are no errors related to chassis_db_init
Why I did it
Error log was shown on switches during boot
How I did it
Add exit code zero as an expected exit code and also disable autorestart.
How to verify it
Boot the switch and ensure the above log line does not appear.
Which release branch to backport (provide reason below if selected)
None. Not a functional bug.
Description for the changelog
[pmon] Fix chassis_db_init exit not being expected
A picture of a cute animal (not mandatory but encouraged)