Add support for RebootMethod_HALT for Reboot API #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdwhdw
reviewed
Sep 16, 2024
hdwhdw
previously approved these changes
Sep 18, 2024
@qiluo-msft Removed the empty lines change. Thank you. |
vvolam
force-pushed
the
os_reboot_halt
branch
from
5f92d40 to
333b570
Compare
hdwhdw
previously approved these changes
Sep 20, 2024
ganglyu
previously approved these changes
Sep 23, 2024
qiluo-msft
previously approved these changes
Oct 31, 2024
vvolam
dismissed stale reviews from qiluo-msft, ganglyu, and hdwhdw
via
fe82369
vvolam
force-pushed
the
os_reboot_halt
branch
from
333b570 to
fe82369
Compare
|
Fixed the merging conflicts. @hdwhdw @ganglyu @qiluo-msft please re-approve. |
hdwhdw
approved these changes
Nov 1, 2024
qiluo-msft
approved these changes
Nov 1, 2024
qiluo-msft
pushed a commit
to sonic-net/sonic-host-services
that referenced
this pull request
Nov 8, 2024
As part of sonic-net/sonic-gnmi#286 changes, we require dbus support for executing HALT method. This PR adds support for execute_reboot for invoking reboot methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add support for HALT reboot method for Reboot gNOI API
How I did it
Implement changes for HaltSystem() function to be called when HALT reboot method is invoked.
How to verify it
Unit tests
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)