Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured events: Publish as JsonIetfVal instead of StringVal #43

Merged
merged 18 commits into from
Oct 6, 2022

Conversation

renukamanavalan
Copy link
Contributor

Why I did it

  1. GWS reader code preferred the format as JsonIetfVal. Hence updated.
  2. SONiC monit code use test events for periodic check. Telemetry client filters it out from events published.
  3. The size of Q used as buffer between received events and write-to-gNMI channel can be tweaked via query params.

How I did it

How to verify it

The gnmi_cli tool now receives as JsonIetfVal.
gnmi_cli tool will never receive test events. You may explicity invoke "/usr/bin/events_monit_test.py" to send those events.
The qsize in use is logged. You may send a size via param and confirm it is taken via telemetry.log.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@renukamanavalan renukamanavalan self-assigned this Oct 5, 2022
@lgtm-com
Copy link

lgtm-com bot commented Oct 5, 2022

This pull request introduces 3 alerts when merging 9299ec7 into 437fc35 - view on LGTM.com

new alerts:

  • 2 for Unreachable statement
  • 1 for Expression has no effect

@renukamanavalan renukamanavalan merged commit 194ecd0 into sonic-net:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants