Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-asic] Fix the issue where if dest port is not specified in ACL rule than caclmgrd gets exception #21

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Sep 26, 2022

What I did:
Fixes: sonic-net/sonic-buildimage#12179

Why I did:
Fix the issue where if dest port is not specified in ACL rule than for multi-asic where we create NAT rule to forward traffic from Namespace to host fail with exception.

How I verify:-
Added UT for the scenario.

multi-asic where we create NAT rule to forward traffic from Namespace to
host fail with exception.
@abdosi abdosi requested a review from ZhaohuiS September 26, 2022 16:07
@ZhaohuiS
Copy link
Contributor

@abdosi Thank you for the quick fix. The change of EXTERNAL_CLIENT was also merged into 202012 and 202205 branch, could you please submit your change into these 2 branches too? Thanks a lot!

@abdosi abdosi merged commit bc8698d into sonic-net:master Sep 28, 2022
@abdosi abdosi deleted the feature branch September 28, 2022 00:39
@anamehra
Copy link
Contributor

anamehra commented Oct 7, 2022

Hi @abdosi , need this fix on the 202205 branch as well. Thanks!

SuvarnaMeenakshi added a commit to sonic-net/sonic-buildimage that referenced this pull request Nov 3, 2022
…d in ACL rule than caclmgrd gets exception (#12577)

Why I did it
Creating this PR to take changes from sonic-net/sonic-host-services#21
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Nov 5, 2022
…d in ACL rule than caclmgrd gets exception (#12577)

Why I did it
Creating this PR to take changes from sonic-net/sonic-host-services#21
ganglyu pushed a commit that referenced this pull request Feb 13, 2023
…d in ACL rule than caclmgrd gets exception (#12577)

Why I did it
Creating this PR to take changes from #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

202205: caclmgrd traceback KeyError: 'dst_ports'
3 participants