Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Hardening: Add support to disable expiration date #93

Merged

Conversation

davidpil2002
Copy link
Contributor

@davidpil2002 davidpil2002 commented Dec 6, 2023

[password-hardening]Add support to disable expiration date like in Linux.-1: expiration will never occur, 0: expiration will expire immediately

This commit is part of the fix to the following bug:
sonic-net/sonic-buildimage#17427

@davidpil2002 davidpil2002 force-pushed the dev-password-hardening-support-dis-exp branch from 3459dd9 to 7daab08 Compare December 6, 2023 14:13
@liat-grozovik
Copy link
Collaborator

@davidpil2002 please check it can be cherry picked to all the branches starting of 202205 as the bug is related to them as well

@davidpil2002
Copy link
Contributor Author

202205

checked, no conflict exist with 202205, 202211, 202305, 202311

@liat-grozovik
Copy link
Collaborator

i have no permission on this repo.
is it ok to leave the one on build image or this will break something till this is not merged?
in this case it is good to have a dependency stated in the pr to avoid such.

@davidpil2002
Copy link
Contributor Author

i have no permission on this repo. is it ok to leave the one on build image or this will break something till this is not merged? in this case it is good to have a dependency stated in the pr to avoid such.

It will not break anything, but, in order to fix the bug I need both.

@dgsudharsan
Copy link
Contributor

@StormLiangMS Tested on top of 202305 commit sonic-net/sonic-buildimage@690c4c5

scripts/hostcfgd Outdated Show resolved Hide resolved
@xumia
Copy link
Contributor

xumia commented Feb 22, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidpil2002
Copy link
Contributor Author

Hi @liuh-80,
Hope all is well, this PR is pending long time, and already answered all the comments/concerns, we required this one to be merge.
pls can you help?

@liat-grozovik
Copy link
Collaborator

@lguohan @qiluo-msft please help with the approval flow. this is on hold for quite sometime. must for 202405. needed for other active branches as stated.

@davidpil2002
Copy link
Contributor Author

@liuh-80 @qiluo-msft
pls can you help with this merge?

@liuh-80 liuh-80 merged commit 39834f2 into sonic-net:master Aug 26, 2024
5 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-host-services that referenced this pull request Sep 11, 2024
)

* password-hardening: Add support to disable expiration date like in Linux (PAM)

* password-hardening: Fix default return of dict to -1 instead None
@mssonicbld
Copy link

Cherry-pick PR to 202405: #163

mssonicbld pushed a commit that referenced this pull request Sep 11, 2024
* password-hardening: Add support to disable expiration date like in Linux (PAM)

* password-hardening: Fix default return of dict to -1 instead None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants