NPU disable unused PCIe BAR #225
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| From 0be339b4c8468138dfe1a30de29511e94b846af6 Mon Sep 17 00:00:00 2001 | ||
| From: Madhava Reddy Siddareddygari <msiddare@cisco.com> | ||
| Date: Mon, 16 Aug 2021 12:55:37 -0700 | ||
| Subject: [PATCH] NPU disable unused PCI BAR | ||
|
|
||
| For Cisco ASIC only BAR0 is valid. Not disabling other BAR's | ||
| was resulting in pci_enable_device function failure in P0 | ||
| Pacific ASIC's. Further debugging and consultion with Hardware | ||
| team, issue seems to be related to only P0 version of ASIC and | ||
| workaround suggested is to disable unused PCI BAR. | ||
|
|
||
|
There was a problem hiding this comment. Please also paste the new log messages from one device to the commit message. |
||
| Signed-off-by: Madhava Reddy Siddareddygari <msiddare@cisco.com> | ||
| --- | ||
| drivers/pci/quirks.c | 54 ++++++++++++++++++++++++++++++++++++++++++++ | ||
| 1 file changed, 54 insertions(+) | ||
|
|
||
| diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c | ||
| index af2149632..8b99883e1 100644 | ||
| --- a/drivers/pci/quirks.c | ||
| +++ b/drivers/pci/quirks.c | ||
| @@ -5462,3 +5462,57 @@ static void apex_pci_fixup_class(struct pci_dev *pdev) | ||
| } | ||
| DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, 0x089a, | ||
| PCI_CLASS_NOT_DEFINED, 8, apex_pci_fixup_class); | ||
| + | ||
| +#define PCI_DEVICE_ID_LEABA_PACIFIC 0xabcd | ||
| +#define PCI_DEVICE_ID_LEABA_GIBRALTAR 0xa001 | ||
| +#define PCI_DEVICE_ID_LEABA_GRAPHENE 0xa003 | ||
| +#define PCI_DEVICE_ID_LEABA_PALLADIUM 0xa004 | ||
| +#define PCI_DEVICE_ID_LEABA_ARGON 0xa005 | ||
| +#define PCI_DEVICE_ID_LEABA_KRYPTON 0xa006 | ||
msiddare marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| + | ||
| +/* | ||
| + * For Pacific A0, only BAR 0 is valid | ||
|
There was a problem hiding this comment. Please add an errata document name and number for reference. |
||
| + */ | ||
| +static void silicon_one_fixup(struct pci_dev *dev) | ||
|
There was a problem hiding this comment. I’d think, the function name needs to include |
||
| +{ | ||
| + int i; | ||
|
There was a problem hiding this comment. This does not follow the Linux coding style. Please check patches with There was a problem hiding this comment. Sorry, Firefox display issues in the browser. |
||
| + struct resource *r; | ||
| + | ||
| + for (i = 1; i <= PCI_ROM_RESOURCE; i++) { | ||
| + r = &dev->resource[i]; | ||
| + if (!r->start && !r->end && !r->flags) | ||
| + continue; | ||
| + | ||
| + dev_info(&dev->dev, | ||
| + "Cisco Silicon One BAR %d %pR disabled due to " | ||
| + "NPU hardware bug in P0 Pacific ASIC\n", i, r); | ||
| + r->start = 0; | ||
| + r->end = 0; | ||
| + r->flags = 0; | ||
| + } | ||
| + /* | ||
| + * Pacific device was misbehaving during rescan not enumerating | ||
| + * memory for bar. Due to this HW issue, added this workaround | ||
| + * and verified that during rescan memory gets assigned properly | ||
| + * to the device. This is only a temporary fix for pacific ASIC | ||
|
Comment on lines
+54
to
+57
There was a problem hiding this comment. Maybe:
|
||
| + * only | ||
|
There was a problem hiding this comment. Is it really temporary? |
||
| + */ | ||
| + dev->class = PCI_CLASS_MEMORY_OTHER << 8; | ||
| + dev_info(&dev->dev, "Cisco Silicon One class adjusted\n"); | ||
| +} | ||
| +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SYNOPSYS, PCI_DEVICE_ID_LEABA_PACIFIC, | ||
|
There was a problem hiding this comment. Why |
||
| + silicon_one_fixup); | ||
| +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CISCO, PCI_DEVICE_ID_LEABA_PACIFIC, | ||
| + silicon_one_fixup); | ||
| +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CISCO, PCI_DEVICE_ID_LEABA_GIBRALTAR, | ||
| + silicon_one_fixup); | ||
| +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CISCO, PCI_DEVICE_ID_LEABA_GRAPHENE, | ||
| + silicon_one_fixup); | ||
| +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CISCO, PCI_DEVICE_ID_LEABA_PALLADIUM, | ||
| + silicon_one_fixup); | ||
| +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CISCO, PCI_DEVICE_ID_LEABA_ARGON, | ||
| + silicon_one_fixup); | ||
| +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_CISCO, PCI_DEVICE_ID_LEABA_KRYPTON, | ||
| + silicon_one_fixup); | ||
| + | ||
| + | ||
| -- | ||
| 2.26.2 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it an upstreamable commit message summary (How to Write a Git Commit Message).