fix driver optoe twoaddr a2h read write bug #434
Conversation
|
@prgeor Could you kindly help to review this request? |
|
@saiarcot895 @paulmenzel @donboll Could you kindly help to review this request? |
|
|
||
| return page; /* note also returning client and offset */ | ||
| } | ||
| +static void optoe_update_client(struct optoe_data *optoe, loff_t *offset, struct i2c_client **client) |
There was a problem hiding this comment.
Please use the Linux kernel coding style. Mainly please use tabs.
There was a problem hiding this comment.
Have used the Linux kernel coding style-use tabs，please help to check again，thank you！
| From 3e289806e5d3c45c6afc2a6caeb935828a5032eb Mon Sep 17 00:00:00 2001 | ||
| From: "Song,Qinghua" <songqh@clounix.com> | ||
| Date: Fri, 20 Sep 2024 19:32:52 +0800 | ||
| Subject: [PATCH] From 4338f175d03e83b3dd187c4d2af193e9e6f86039 Mon Sep 17 |
There was a problem hiding this comment.
This still looks incorrect. The [PATCH] tag does not belong here.
|
Shouldn’t you first open a merge/pull request against the branch master? |
|
Also, why 202012 branch? This branch is almost 4 years old. |
songqh2022
force-pushed
the
202012
branch
2 times, most recently
from
4bfc223 to
a133d96
Compare
|
@saiarcot895 because this branch is also used by some users ,eg, Clounix. Also I will push it to the master branch after this request is merged, thank you! |
Signed-off-by: Qinghua Song <songqh@clounix.com>
|
@songqh2022 Please create the master branch PR first. The general process is that changes go into the master branch first, then are backported to older branches, unless a change is not applicable to the master branch. |
the page select register(127) only in the a0h from sfp8472 spec, so when access the a2h , the function optoe_translate_offset will update the slave_addr=a2h, and then using this slave_addr to config the page slelect register, so the contents is wrong.