[Kernel] support downloading built kernel Debian packages #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
jleveque
reviewed
Jul 2, 2018
Makefile
Outdated
| @@ -1,6 +1,38 @@ | |||
| .ONESHELL: | |||
| SHELL = /bin/bash | |||
|
|
|||
| ifneq ($(kernel_build_method), "build") | |||
There was a problem hiding this comment.
How does one set kernel_build_method? Should this become a command-line parameter specified in rules/config?
There was a problem hiding this comment.
It is. Please take a look at the linked PR.
There was a problem hiding this comment.
Aha. Sorry, missed the linked PR.
A small concern is the terminology might not be intuitive (i.e., that one of the "build methods" is "download" which doesn't actually build anything). I think a name like "kernel_procure_method" is more accurate. Maybe someone else has another suggestion?
There was a problem hiding this comment.
procure is good. Thanks.
jleveque
approved these changes
Jul 2, 2018
lguohan
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to download pre-built Linux kernel Debian packages instead of building from source files.
This change prefers the method of download over build.
Signed-off-by: Ying Xie ying.xie@microsoft.com
Note: this PR is better go in after sonic-net/sonic-buildimage#1837 but it doesn't have to.