Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Gap][BGP][T2] Missing specific cases of TSA on sup effect on LCs #14850

Closed
Javier-Tan opened this issue Oct 5, 2024 · 2 comments · Fixed by #14855
Closed

[Test Gap][BGP][T2] Missing specific cases of TSA on sup effect on LCs #14850

Javier-Tan opened this issue Oct 5, 2024 · 2 comments · Fixed by #14855
Assignees

Comments

@Javier-Tan
Copy link
Contributor

Javier-Tan commented Oct 5, 2024

Test Gap Description

The following behaviour is not being tested:

  • If Supervisor tsa_enabled == TRUE, operational state is TSA(TRUE). In this configuration
    • A. After the Line card reboots - the operational state will be TSA when the Line card comes back up. The "startup_tsa_tsb" service will still set the local CONFIG_DB attribute and start a timer. If the timer expires while Supervisor is still "tsa_enabled", the operational state will still be TSA.
    • D. The Line Card "startup_tsa_tsb" service will still kick-in after a LC reboot After a Line Card

This is defined/stated in https://github.com/sonic-net/SONiC/blob/master/doc/voq/Reliable_TSA.md

Test Plan

Add testcase to test_startup_tsa_tsb_service.py to test LCs still execute startup_tsa_tsb service
and remain in TSA state after startup_tsa_tsb service is finished

Test environment

Topology: T2

Attach files (if any)

N/A

@Javier-Tan Javier-Tan self-assigned this Oct 5, 2024
@Javier-Tan
Copy link
Contributor Author

@arlakshm for vis

@Javier-Tan Javier-Tan changed the title [Test Gap][BGP][T2] Missing tests for TSA on sup affect on LCs startup_tsa_tsb service behaviour [Test Gap][BGP][T2] Missing tests for TSA on sup effect on LCs startup_tsa_tsb service behaviour Oct 6, 2024
@Javier-Tan Javier-Tan changed the title [Test Gap][BGP][T2] Missing tests for TSA on sup effect on LCs startup_tsa_tsb service behaviour [Test Gap][BGP][T2] TSA on sup affect on LCs startup_tsa_tsb service behaviour Oct 6, 2024
@Javier-Tan Javier-Tan changed the title [Test Gap][BGP][T2] TSA on sup affect on LCs startup_tsa_tsb service behaviour [Test Gap][BGP][T2] TSA on sup effect on LCs startup_tsa_tsb service behaviour Oct 7, 2024
@Javier-Tan Javier-Tan changed the title [Test Gap][BGP][T2] TSA on sup effect on LCs startup_tsa_tsb service behaviour [Test Gap][BGP][T2] Missing specific cases of TSA on sup effect on LCs Oct 7, 2024
@Javier-Tan
Copy link
Contributor Author

Reducing scope as #13290 covers the rest of what I thought was missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant