[action] [PR:14855] [BGP TSA/TSB] Update tests execute TSA/TSB on sup cards, refactor test py files slightly, cover test gaps, bug fixes #15093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor test py files slightly, cover test gaps, bug fixes (sonic-net#14855) What is the motivation for this PR? To fix bug causing exceptions when running TSA/TSB on supervisor cards in test_traffic_shift_sup.py and test_startup_tsa_tsb_service.py and also while there refactor test_traffic_shift_sup.py to be cleaner. How did you do it? Change TSA/TSB to be run directly through suphost and not through function that is only required for rexec. See changes for other refactors. How did you verify/test it? Ran tests on T2 testbed to see that they were running as expected, no more exceptions being raised. Signed-off-by: javiertan@microsoft.com Signed-off-by: Javier Tan javiertan@microsoft.com
8 tasks
|
Original PR: #14855 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #14843 & Fixes #14850 & Fixes #14903
Update how tests execute TSA/TSB on chassis supervisor cards, additionally light refactor of test_traffic_shift_sup.py to be cleaner.
Type of change
Back port request
Approach
What is the motivation for this PR?
To fix bug causing exceptions when running TSA/TSB on supervisor cards in
test_traffic_shift_sup.pyandtest_startup_tsa_tsb_service.pyand also while there refactortest_traffic_shift_sup.pyto be cleaner.How did you do it?
Change TSA/TSB to be run directly through suphost and not through function that is only required for rexec. See changes for other refactors.
How did you verify/test it?
Ran tests on T2 testbed to see that they were running as expected, no more exceptions being raised.
Any platform specific information?
Platform agnostic
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A