[platform] Fix the reboot SONiC stuck issue #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 24, 2019 19:25
* Fix the reboot stucking issue by replacing multiprocessing.pool with multiprocessing.ThreadPool * Add uptime check in rebooting * Fix the issue of checking dameon status in pmon * Improve the logging while checking interface status * Fix some code style issues to comply with PEP8 Signed-off-by: Xin Wang <xinw@mellanox.com>
yvolynets-mlnx
approved these changes
Sep 26, 2019
jleveque
suggested changes
Sep 27, 2019
jleveque
approved these changes
Sep 27, 2019
lguohan
pushed a commit
that referenced
this pull request
Oct 8, 2019
* Porting back pytest change from master to 201811 update device info to add more facts add log analyzer add check daemon status test add check interface status test add Mellanox check sfp presence test update reboot, config reload and sequential restart test update sfp test update check sysfs test update platform fixture * fix review comments Rebase to add some new master PR: #1130 [platform] Fix the reboot SONiC stuck issue #1120 [platform] Disable log analyzer for the reload and restart cases #1125 [pytest] Fix pytest conftest.py issue * update loganalyzer ignore log * [tests/platform/mellanox] check PSU state against sysfs on Mellanox devices (#1082) * [psu test case] check psu state against vendor specific info. for mellanox, check sysfs * [test_platform_info.py]handle "NOT PRESENT" in test_show_platform_psustatus * [psu testcase] address comments Conflicts: tests/platform/mellanox/check_sysfs.py * [check_sysfs] rewords. * [check_sysfs.py] rewording Conflicts: tests/platform/mellanox/check_sysfs.py * reduce redundant code and rename function * remove redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The original code used multiprocessing.pool to issue "reboot" command to DUT in asyncnourous way. When there is issue with rebooting, killing the pool may stuck there like forever. Main purpose of this PR is to fix this issue.
Changes:
with multiprocessing.ThreadPool
Type of change
Approach
How did you do it?
Replace multiprocessing.pool with multiprocessing.ThreadPool. Add uptime check in rebooting.
How did you verify/test it?
Tested on mellanox platform
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation