Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_reload_config issue #11674

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

JibinBao
Copy link
Contributor

@JibinBao JibinBao commented Feb 8, 2024

Description of PR

Fix issue:#11654

  1. Revert PR: Stabilize test_reload_configuration_checks #7289, because the relevant issue has been fixed by PR:Re-add 127.0.0.1/8 when bringing down the interfaces sonic-buildimage#15080
  2. Remove wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: Improvising pre_checks for test_reload config  #7953 due to the above same reason

Summary:
Fixes # (issue)#11654

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Fix issue:#11654

How did you do it?

  1. Revert PR: Stabilize test_reload_configuration_checks #7289, because the relevant issue has been fixed by PR:Re-add 127.0.0.1/8 when bringing down the interfaces sonic-buildimage#15080
  2. Remove wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: Improvising pre_checks for test_reload config  #7953 due to the above same reason

How did you verify/test it?

Run test_reload_config.py

Any platform specific information?

Any

Supported testbed topology if it's a new test case?

Documentation

@JibinBao JibinBao requested a review from prgeor as a code owner February 8, 2024 06:49
1. Revert PR: sonic-net#7289, because the relevant issue has been fixed by PR:sonic-net/sonic-buildimage#15080
2. Remove  wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: sonic-net#7953 due to the above same reason

Change-Id: Ifde0a83020bb06fb191a646e5ca91738b864ad7f
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/platform_tests/test_reload_config.py:10:1: F401 're' imported but unused

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@liat-grozovik
Copy link
Collaborator

@JibinBao is this duplicate PR with 11675?

@JibinBao
Copy link
Contributor Author

@JibinBao is this duplicate PR with 11675?

@liat-grozovik , it is not duplicated with #11675.
Because there are some conflicts, so I opened #11675 for branch 202205

@wangxin wangxin merged commit a84fce7 into sonic-net:master Mar 4, 2024
17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 4, 2024
1. Revert PR: sonic-net#7289, because the relevant issue has been fixed by PR:sonic-net/sonic-buildimage#15080
2. Remove  wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: sonic-net#7953 due to the above same reason
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #11850

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 4, 2024
1. Revert PR: sonic-net#7289, because the relevant issue has been fixed by PR:sonic-net/sonic-buildimage#15080
2. Remove  wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: sonic-net#7953 due to the above same reason
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #11851

wangxin pushed a commit that referenced this pull request Mar 4, 2024
Cherry-pick #11674 to 202205 branch
1. Revert PR: #7289, because the relevant issue has been fixed by PR:sonic-net/sonic-buildimage#15080
2. Remove  wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: #7953 due to the above same reason
mssonicbld pushed a commit that referenced this pull request Mar 4, 2024
1. Revert PR: #7289, because the relevant issue has been fixed by PR:sonic-net/sonic-buildimage#15080
2. Remove  wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: #7953 due to the above same reason
mssonicbld pushed a commit that referenced this pull request Mar 4, 2024
1. Revert PR: #7289, because the relevant issue has been fixed by PR:sonic-net/sonic-buildimage#15080
2. Remove  wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: #7953 due to the above same reason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants