Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py.test/TestbedProcessing] Fixes for py.test #1257

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

msosyak
Copy link
Contributor

@msosyak msosyak commented Dec 3, 2019

Description of PR

Tried to run test_bgp_speaker and faces some issues

  • missed "ptf" in testbed
  • missed --module-path= in pytest_cmd
  • inventory_file contains absolute path not relative
  • dut.host.options["inventory_manager"].get_vars failed with undefined method

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

Fixed

How did you verify/test it?

Run a few py.test testcases

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

ansible/roles/test/tasks/pytest_runner.yml Show resolved Hide resolved
ansible/TestbedProcessing.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
@lguohan lguohan merged commit 2723722 into sonic-net:master Dec 10, 2019
neethajohn pushed a commit to neethajohn/sonic-mgmt that referenced this pull request Jan 8, 2021
…ic changes

Add 'ptf' column which contains the name of the PTF host from the inventory file to comply with public commit: sonic-net#1257. Without this addition, pytest-ansible will fail.
bingwang-ms pushed a commit to bingwang-ms/sonic-mgmt that referenced this pull request May 20, 2021
…ic changes

Add 'ptf' column which contains the name of the PTF host from the inventory file to comply with public commit: sonic-net#1257. Without this addition, pytest-ansible will fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants