Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional test cases to verify 'startup_tsa_tsb.service' - PR#18496 PR#12238 #12781

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

sanjair-git
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

To verify code changes introduced as part of the PR #sonic-net/sonic-buildimage#18496

How did you do it?

  • Added 4 more new test cases as mentioned below to verify the changes.
  • Attaching updated test cases' description document with all 9 test cases here for further reference and details.
    BGP-TSA-TSB-Service-TestCases.txt
  1. test_user_init_tsa_while_service_run_on_dut
  2. test_user_init_tsb_while_service_run_on_dut
  3. test_user_init_tsb_on_sup_while_service_run_on_dut
  4. test_tsa_tsb_timer_efficiency

How did you verify/test it?

  • Ran all the above mentioned test cases on a T2 chassis and made sure tests passed with expected behavior.

Commit Id to review as part of this PR: @tjchadaga
3b6b38e9e4cb425f34225163dcf1f7f732b1e083 -- (New testcases for tsa_tsb_service feature)

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

image

@sanjair-git sanjair-git requested a review from StormLiangMS as a code owner May 9, 2024 16:08
@sanjair-git sanjair-git force-pushed the tsa_tsb_service_new branch from 3b6b38e to e90d4d9 Compare May 15, 2024 17:02
@sanjair-git
Copy link
Contributor Author

@tjchadaga, Thanks for looking into it. I have resolved the comments for the new test cases. Rerun them and please find the results below.

image

@rlhui
Copy link

rlhui commented May 28, 2024

@sanjair-git please resolve conflict

@abdosi
Copy link
Contributor

abdosi commented May 28, 2024

@sanjair-git : Please help resolve conflict.

@sanjair-git sanjair-git force-pushed the tsa_tsb_service_new branch from e90d4d9 to 1e1ac7a Compare May 29, 2024 15:37
@sanjair-git
Copy link
Contributor Author

@sanjair-git please resolve conflict

Hi @rlhui, rebased and resolved conflict.

@sanjair-git
Copy link
Contributor Author

@sanjair-git : Please help resolve conflict.

Hi @abdosi , rebased and resolved conflict.

@sanjair-git sanjair-git force-pushed the tsa_tsb_service_new branch from 1e1ac7a to 81a1b62 Compare June 18, 2024 19:34
@rlhui rlhui removed the request for review from StormLiangMS July 5, 2024 17:07
@rlhui rlhui merged commit 40186b7 into sonic-net:master Jul 5, 2024
14 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 10, 2024
…PR#12238 (sonic-net#12781)

This PR has additional new test cases to verify the changes introduced as part of # Linecard startup-TSA-TSB sonic-buildimage#18496.
This PR is dependent on PR Tests to verify 'startup_tsa_tsb.service' during linecard bring up - PR#18496 sonic-net#12238
Basically, this PR has new 4 test cases in addition to the 5 test cases added to verify start and stop of the new service 'startup_tsa_tsb.service' introduced by PR Tests to verify 'startup_tsa_tsb.service' during linecard bring up - PR#18496 sonic-net#12238
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #13622

mssonicbld pushed a commit that referenced this pull request Jul 13, 2024
…PR#12238 (#12781)

This PR has additional new test cases to verify the changes introduced as part of # Linecard startup-TSA-TSB sonic-buildimage#18496.
This PR is dependent on PR Tests to verify 'startup_tsa_tsb.service' during linecard bring up - PR#18496 #12238
Basically, this PR has new 4 test cases in addition to the 5 test cases added to verify start and stop of the new service 'startup_tsa_tsb.service' introduced by PR Tests to verify 'startup_tsa_tsb.service' during linecard bring up - PR#18496 #12238
arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this pull request Oct 2, 2024
…PR#12238 (sonic-net#12781)

This PR has additional new test cases to verify the changes introduced as part of # Linecard startup-TSA-TSB sonic-buildimage#18496.
This PR is dependent on PR Tests to verify 'startup_tsa_tsb.service' during linecard bring up - PR#18496 sonic-net#12238
Basically, this PR has new 4 test cases in addition to the 5 test cases added to verify start and stop of the new service 'startup_tsa_tsb.service' introduced by PR Tests to verify 'startup_tsa_tsb.service' during linecard bring up - PR#18496 sonic-net#12238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants