Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv4 decapsulation test #128

Merged
merged 12 commits into from
Mar 20, 2017
Merged

IPv4 decapsulation test #128

merged 12 commits into from
Mar 20, 2017

Conversation

engdorm
Copy link
Contributor

@engdorm engdorm commented Feb 21, 2017

Added IPv4 decap test for testing IPv4 decapsulation on Sonic

new files :
IP_decap_test.py - the PTF test
decap.yml - the Ansible script for running the test
decap_conf.j2 - template for creating decap rule configuration

Modified files:
sonic.yml - added decap test
router_utils - added parsing function for routes_info.txt

@engdorm engdorm changed the title Master IPv4 decapsulation test Feb 21, 2017

- include: roles/test/files/tools/loganalyzer/loganalyzer_init.yml

- debug : msg="INVOKE FIB TEST"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIB -> IPv4 decap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


- debug: var=out.stdout_lines
when: out.rc != 0

Copy link

@andriymoroz andriymoroz Feb 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuration is not removed from the switch after test finishes/fails
I'm not sure how TUNNEL_DECAP_TABLE is handled but it is possible in the log there could be some "already exist" error messages when test is rerun and log analyzer will treat them as an error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@engdorm engdorm mentioned this pull request Feb 26, 2017
outer_ttl = random.randint(2, 63)
sport=1234
dport=80
if ("pipe" == self.test_params['dscp_mode']):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please put values from lines 77 to 87 into simple_tcp_packet() and simple_ipv4ip_packet()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some fields only filled once as some parameters only for the inner (end with *_in) and some for only the outer
in addition, simple_ipv4ip_packet there isn't all of the fields like simple_tcp_packet
its only another layer of L2 and L3

But in simple_tcp_packet I added tcp ports for more detailed code
Because it's the default values, so it will not change anything

@oleksandrivantsiv oleksandrivantsiv merged commit 7b2ba21 into sonic-net:master Mar 20, 2017
lguohan pushed a commit that referenced this pull request Aug 3, 2017
* decap test v1

* decap test added

* checkout on fib_test

* restoring ACL test

* fixes

* fix #2

* removed decap configuration in the test

* added tcp port fields to simple_tcp_packet

* removed some vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants