Add BBR testcases #14117
Merged
Add BBR testcases #14117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gfrom2016
force-pushed
the
add_bbr_testcase
branch
from
a59dea4
to
3a16ca2
Compare
Gfrom2016
force-pushed
the
add_bbr_testcase
branch
from
3a16ca2
to
5269d1f
Compare
Gfrom2016
requested review from
StormLiangMS,
wangxin and
yxieca
as code owners
Gfrom2016
force-pushed
the
add_bbr_testcase
branch
from
5269d1f
to
a8db02b
Compare
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZhaohuiS
reviewed
Sep 9, 2024
| @pytest.fixture(scope='module') | ||
| def setup(duthosts, rand_one_dut_hostname, tbinfo, nbrhosts): | ||
| duthost = duthosts[rand_one_dut_hostname] | ||
|
|
||
| constants_stat = duthost.stat(path=CONSTANTS_FILE) | ||
| if not constants_stat['stat']['exists']: | ||
| pytest.skip('No file {} on DUT, BBR is not supported') | ||
| pytest.skip('No constants.yml file on DUT, BBR is not supported') |
There was a problem hiding this comment.
If there is no constants.yml, is it a correct status? In my understanding, constants.yml should store many constans, right? If the file doesn't exist, it is in fatal condition, not just BBR is not supported, we have to fail the case, not just skip it, is it correct?
There was a problem hiding this comment.
I don't think constants file not exist should fail the case, it's not the bbr case's responsibility to make sure the file exists.
Gfrom2016
force-pushed
the
add_bbr_testcase
branch
from
13b3835
to
77e8a79
Compare
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
|
hi @ZhaohuiS any concern to approve? |
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? Add a new case to verify the BBR initialized behavior. How did you do it? Add the following new case under test_bgp_bbr.py test_bbr_status_consistent_after_reload How did you verify/test it? https://dev.azure.com/mssonic/internal/_build/results?buildId=619063&view=results
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Oct 10, 2024
What is the motivation for this PR? Add a new case to verify the BBR initialized behavior. How did you do it? Add the following new case under test_bgp_bbr.py test_bbr_status_consistent_after_reload How did you verify/test it? https://dev.azure.com/mssonic/internal/_build/results?buildId=619063&view=results
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 12, 2024
What is the motivation for this PR? Add a new case to verify the BBR initialized behavior. How did you do it? Add the following new case under test_bgp_bbr.py test_bbr_status_consistent_after_reload How did you verify/test it? https://dev.azure.com/mssonic/internal/_build/results?buildId=619063&view=results
|
Cherry-pick PR to 202405: #14975 |
8 tasks
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
What is the motivation for this PR? Add a new case to verify the BBR initialized behavior. How did you do it? Add the following new case under test_bgp_bbr.py test_bbr_status_consistent_after_reload How did you verify/test it? https://dev.azure.com/mssonic/internal/_build/results?buildId=619063&view=results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
After the fix in sonic-net/sonic-buildimage#19590, add a new test case to test the bbr behavior after config reload.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Add a new case to verify the BBR initialized behavior.
How did you do it?
Add the following new case under test_bgp_bbr.py
test_bbr_status_consistent_after_reload
How did you verify/test it?
https://dev.azure.com/mssonic/internal/_build/results?buildId=619063&view=results
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation