Add test case for testing zero source MAC address handling in dualtor #14693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janetxxx <janet970527@gmail.com>
Signed-off-by: Janetxxx <janet970527@gmail.com>
lolyu
reviewed
Sep 23, 2024
| test_ports = random.sample(list(mux_configs.keys()), 2) | ||
| logging.info("Selected test ports: %s", pprint.pformat(test_ports)) | ||
| # send zero source MAC ICMP packets from the selected ports | ||
| zero_mac_packet_sender = send_zero_mac_packets(test_ports) |
There was a problem hiding this comment.
The fanout switches might drop those packets as it has zero src mac, so the device cannot receive them.
Could you pls confirm?
There was a problem hiding this comment.
You might have to start a script on leaf fanout to send packets. There should be some examples in pfcwd test cases.
There was a problem hiding this comment.
having a script running the DUT to send/receive heartbeats could also work
Janetxxx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add test case to Hackathon testgap #9344
Type of change
Back port request
Approach
What is the motivation for this PR?
Cover the scenario when two servers in the same rack are down together, invalid source MAC address from two ports should not be learned by the dualtor.
How did you do it?
Generate and send ICMP packets with a zero source MAC address from two randomly selected ports and verify that the MAC table doesn't contain the zero MAC (the zero MAC shouldn't be learned).
How did you verify/test it?
Validate it in internal setup
Any platform specific information?
vms21-dual-t0-7260
Supported testbed topology if it's a new test case?
dualtor-120
Documentation